Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin] Refactor "accounts/show" view into a separate component #5292

Closed
rainerdema opened this issue Jul 31, 2023 · 2 comments · Fixed by #5294
Closed

[Admin] Refactor "accounts/show" view into a separate component #5292

rainerdema opened this issue Jul 31, 2023 · 2 comments · Fixed by #5294

Comments

@rainerdema
Copy link
Contributor

rainerdema commented Jul 31, 2023

In relation to this comment, it has been suggested that the "account/show" view could be refactored into a separate component.

The goal of this issue is to create a new component, accounts/show, that will encapsulate the existing functionality of the "account/show" view.

The resulting implementation should allow the "account/show" view to be rendered as follows:

# admin/app/views/solidus_admin/accounts/show.html.erb
<%= render component('accounts/show').new(
      email: current_solidus_admin_user.email,
      logout_path: solidus_admin_logout_path,
      logout_method: solidus_admin_logout_method,
    )
%>
@elia
Copy link
Member

elia commented Jul 31, 2023

@rainerdema I changed the account link to point toward the legacy edit user link, I think we can postpone this until we have designs, wdyt?

@elia
Copy link
Member

elia commented Aug 10, 2023

We'll tackle the account section later, for now we turned the page into a redirect to admin_user_edit_path

@elia elia closed this as not planned Won't fix, can't repro, duplicate, stale Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants