cannot set pin using solo1 due to "'Fido2Client' object has no attribute 'client_pin'"

[vladak]

solo1-cli version 0.1.1 (with changes matching PR #153), and brand new Solokey with updated firmware:

$ solo1 ls
:: Solos
None: SoloKeys Solo 4.1.5

and it is not possible to change the default PIN:

$ solo1 key change-pin
Please enter old pin: 
Please enter new pin: 
Please confirm new pin: 
'Fido2Client' object has no attribute 'client_pin'

$ solo1 key set-pin
Please enter new pin: 
Please confirm new pin: 
'Fido2Client' object has no attribute 'client_pin'

I installed the solo1 via the usual means (Python venv + pip install).

The fido2 package is at version 1.0.0.

[vladak]

This seems to be actually a bug. Both commands reference the client_key property:

solo1-cli/solo/devices/base.py

Lines 81 to 87 in 5b0fde3

	def change_pin(self, old_pin, new_pin):
	client = self.get_current_fido_client()
	client.client_pin.change_pin(old_pin, new_pin)
	def set_pin(self, new_pin):
	client = self.get_current_fido_client()
	client.client_pin.set_pin(new_pin)

however it seems to be moved somewhere else in fido2 1.0.0 via Yubico/python-fido2@6ce5291

[vladak]

I verified that the incompatibility with fido2 is the cause - cloned the solo1-cli repo, changed fido2 >= 0.9.1 in pyproject.toml to fido2 == 0.9.1, rebuilt using make init and it is possible to set-pin once again.

[vladak]

Changing the base.py code to this (assumes from fido2.ctap2.pin import ClientPin):

    def change_pin(self, old_pin, new_pin):                                     
        client = self.get_current_fido_client()                                 
        client_pin = ClientPin(client._backend.ctap2)                           
        client_pin.change_pin(old_pin, new_pin)                                 
                                                                                
    def set_pin(self, new_pin):                                                 
        client = self.get_current_fido_client()                                 
        client_pin = ClientPin(client._backend.ctap2)                           
        client_pin.set_pin(new_pin)

seems to make the set/change PIN operations work again, however at the cost of grabbing private property (_backend) of the Fido2Client object, plus assuming this is actually CTAP2 flavor. So quick and dirty hack, however I don't see another way to do it. @dainnilsson ?

There are still more changes to be done to transition to fido2 1.0.0, e.g.:

$ solo1 key verify
PIN: 
Please press the button on your Solo key
Traceback (most recent call last):
  File "/home/.../solo1/env/bin/solo1", line 8, in <module>
    sys.exit(solo_cli())
  File "/home/.../solo1/env/lib/python3.8/site-packages/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
  File "/home/...l/solo1/env/lib/python3.8/site-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
  File "/home/.../solo1/env/lib/python3.8/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/.../solo1/env/lib/python3.8/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/.../solo1/env/lib/python3.8/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/.../solo1/env/lib/python3.8/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/home/.../solo1/env/lib/python3.8/site-packages/solo/cli/key.py", line 363, in verify
    cert = key.make_credential(pin=pin)
  File "/home/.../solo1/env/lib/python3.8/site-packages/solo/devices/base.py", line 103, in make_credential
    result = client.make_credential(options, pin=pin)
TypeError: make_credential() got an unexpected keyword argument 'pin'

[mcepl]

Shouldn’t we do something like https://github.com/Yubico/python-fido2/blob/main/fido2/client.py#L447?

    client_pin = ClientPin(Ctap2(device))

i.e., getting client_pin from the current device? We do know, what’s our current device, don’t we?