Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

running after a pip3 install and make init both fail after recent update to fido2 library #151

Open
kms15 opened this issue Jun 9, 2022 · 11 comments · May be fixed by #152
Open

running after a pip3 install and make init both fail after recent update to fido2 library #151

kms15 opened this issue Jun 9, 2022 · 11 comments · May be fixed by #152

Comments

@kms15
Copy link

kms15 commented Jun 9, 2022

The fido2 library has renamed the CTAP1 class to Ctap1 and CTAP2 class to Ctap2, deprecating the old names, and they appear to have removed the old names in the newest version of the fido2 library (currently 1.0.0).

This causes errors when using "make init" or trying to run the solo1 cli after installing it with pip3, as it will get the latest version of the fido2 library and crash with the following error:

ImportError: cannot import name 'CTAP1' from 'fido2.ctap1' ([...]/solo1-cli/venv/lib/python3.10/site-packages/fido2/ctap1.py)

Pinning the fido2 package to version 0.9.2 fixes the crash, but probably the solo1-cli code should be updated to match the most recent (and hopefully stable) API of the fido2 library.

@gunterkoenigsmann
Copy link

For me the linked pull request resolves this issue and #153.

@hasufell
Copy link

hasufell commented Dec 1, 2022

Half a year later, this project is still broken on pip.

@sseide
Copy link

sseide commented Dec 1, 2022

applying the patch from @wuxxin fixed the issue. Can Solokeys please merge it and release a new version? should be 10 minutes work...
@0x0ece @conorpp @hoos97 @nickray

@johnnyasantoss
Copy link

Just downloaded in a new computer and got this error again (I remember reading this thread before)

@johnnyasantoss
Copy link

Manually pinning fido2 using pip3 install fido2==0.9.3 makes cli work again, but that's not ideal

@jhuylebroeck
Copy link

I'm not a coder myself, and I had a hard time resolving this issue. Thanks for the workaround, but I'd love a full update and solution.

@AWHubGit
Copy link

I'm not a coder myself, and I had a hard time resolving this issue. Thanks for the workaround, but I'd love a full update and solution.

Me too. Manually pinning fido2 using pip3 install fido2==0.9.3 makes cli working again, but I would like the latest version of the fido2 library.

Is it a secuirity flaw still to have CTAP1 class?

@shetyeshail
Copy link

I'm running into this issue as well. Pinning the pip fido2 library version to 0.9.3 as suggested by johnnyasantoss worked for me, but would appreciate an official patch to the solo1-cli tool. I believe the pull request from wuxxin would do the trick.

@GoetzGoerisch
Copy link

Ping @0x0ece @conorpp @hoos97 @nickray
Please update the current solo1-cli version. Thank you.

@tomash
Copy link

tomash commented Nov 24, 2023

I'm also asking to update the current solo1-cli version, manual search-and-replace in installed pip package (or fixing fido2 to an old version) is a poor experience.

@Jookia
Copy link

Jookia commented Oct 11, 2024

Just for anyone interested, this lets you install solo1 using pipx:

pipx install --preinstall "fido2==0.9.3" solo1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.