Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid CBOR in GetInfo response #170

Closed
agl opened this issue Apr 10, 2019 · 3 comments · Fixed by #171
Closed

Invalid CBOR in GetInfo response #170

agl opened this issue Apr 10, 2019 · 3 comments · Fixed by #171

Comments

@agl
Copy link
Contributor

agl commented Apr 10, 2019

Just poking at this device with Chrome, after flashing firmware 2.1.0:

Chrome rejects the GetInfo response because the CBOR is invalid and thus treats this firmware revision as U2F-only. Specifically, the entries in the CBOR map are incorrectly ordered. See section 6 on ordering.

@conorpp conorpp mentioned this issue Apr 10, 2019
@conorpp
Copy link
Member

conorpp commented Apr 10, 2019

Thanks for reporting. I just pushed a fix for this and tested Chrome is able to register+auth with FIDO2 without falling back to U2F.

Do you have a hacker/reprogrammable Solo and would be able to test on your side? If so, you can update with my fix.

solo.hex.zip

pip3 install python-solo
unzip solo.hex.zip
solo program bootloader solo.hex

@0x0ece
Copy link
Member

0x0ece commented Apr 11, 2019

Good catch! Just tested this new firmware on Safari 12.1, the future is passwordless :)

Screen Shot 2019-04-10 at 8 58 49 PM

@agl
Copy link
Contributor Author

agl commented Apr 12, 2019

Do you have a hacker/reprogrammable Solo and would be able to test on your side? If so, you can update with my fix.

I have one on order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants