I have added CTI support in this fork #139
Conversation
…ll refactoring of the class is done. So to reduce duplicate code.
AuditReader: remove unused EntityManager namespace
| if (!$this->metadataFactory->isAudited($className)) { | ||
| throw new NotAuditedException($className); | ||
| throw AuditException::notAudited($className); |
There was a problem hiding this comment.
@vasil-yordanov You may have forgotten to add the AuditException file.
There was a problem hiding this comment.
Hi,
Isn't this the same as
new NotAuditedException($className);
?
Have you merged my branch to master?
Regards,
Vasil.
On Fri, Oct 9, 2015 at 8:25 PM, Simon Mönch [email protected]
wrote:
In src/SimpleThings/EntityAudit/AuditReader.php
#139 (comment)
:if (!$this->metadataFactory->isAudited($className)) {
throw new NotAuditedException($className);throw AuditException::notAudited($className);@vasil-yordanov https://github.com/vasil-yordanov You may have
forgotten to add the AuditException file.—
Reply to this email directly or view it on GitHub
https://github.com/simplethings/EntityAudit/pull/139/files#r41655545.
There was a problem hiding this comment.
No, NotAuditedException isn't the same name as AuditException 😉 Do you forget a use statement or adding the class?
The builds are failed, see https://travis-ci.org/simplethings/EntityAudit/builds/69906870
PHP Fatal error: Class 'SimpleThings\EntityAudit\AuditException' not found in /home/travis/build/simplethings/EntityAudit/src/SimpleThings/EntityAudit/AuditReader.php on line 411
There was a problem hiding this comment.
ok I will fix this tomorrow.
Regards,
Vasil
On Fri, Oct 16, 2015 at 6:37 PM, David Badura [email protected]
wrote:
In src/SimpleThings/EntityAudit/AuditReader.php
#139 (comment)
:if (!$this->metadataFactory->isAudited($className)) {
throw new NotAuditedException($className);throw AuditException::notAudited($className);No, NotAuditedException isn't the same name as AuditException [image:
😉] Do you forget a use statement or add the class?The builds are failed, see
https://travis-ci.org/simplethings/EntityAudit/builds/69906870PHP Fatal error: Class 'SimpleThings\EntityAudit\AuditException' not found in /home/travis/build/simplethings/EntityAudit/src/SimpleThings/EntityAudit/AuditReader.php on line 411
—
Reply to this email directly or view it on GitHub
https://github.com/simplethings/EntityAudit/pull/139/files#r42256206.
There was a problem hiding this comment.
Hello, I'm very sorry for my late response.
I fixed this issue.
Please let me know if there is still some chance to include my changes in
your code.
Regards,
Vasil.
On Fri, Oct 16, 2015 at 10:18 PM, Vasil Yordanov [email protected]
wrote:
ok I will fix this tomorrow.
Regards,
Vasil
On Fri, Oct 16, 2015 at 6:37 PM, David Badura [email protected]
wrote:In src/SimpleThings/EntityAudit/AuditReader.php
#139 (comment)
:if (!$this->metadataFactory->isAudited($className)) {
throw new NotAuditedException($className);throw AuditException::notAudited($className);No, NotAuditedException isn't the same name as AuditException [image:
😉] Do you forget a use statement or add the class?The builds are failed, see
https://travis-ci.org/simplethings/EntityAudit/builds/69906870PHP Fatal error: Class 'SimpleThings\EntityAudit\AuditException' not found in /home/travis/build/simplethings/EntityAudit/src/SimpleThings/EntityAudit/AuditReader.php on line 411
—
Reply to this email directly or view it on GitHub
https://github.com/simplethings/EntityAudit/pull/139/files#r42256206.
No, NotAuditedException isn't the same name as AuditException 😉 Do you forget a use statement or add the class? The builds are failed, see https://travis-ci.org/simplethings/EntityAudit/builds/69906870 PHP Fatal error: Class 'SimpleThings\EntityAudit\AuditException' not found in /home/travis/build/simplethings/EntityAudit/src/SimpleThings/EntityAudit/AuditReader.php on line 411
|
it has merge conflicts - can you it rebase please? |
|
Ok, I will do it now On Tue, Nov 10, 2015 at 1:51 PM, David Badura [email protected]
|
|
Hello David, It seems this is not a trivial merge I will need more time to do that, will Regards, Vasil. On Tue, Nov 10, 2015 at 1:57 PM, Vasil Yordanov [email protected]
|
|
great work 👍 |
|
no problem. i would like to merge it before #159. thank you! |
|
Hello David, I give up to do the merge, its too complex. It seems that currently the feature (excluding the code refactoring) that I However in my latest commit I did the following:
I will try some shiny day to continue with the refactoring of the Regards, Vasil. On Tue, Nov 10, 2015 at 3:33 PM, David Badura [email protected]
|
|
@vasil-yordanov Could you please open a new clean PR with your latest changes? Thanks in advance |
No description provided.