[#318] Add conflict with "doctrine/dbal:2.7.0" #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phansys
changed the title
null => true in CreateSchemaListener::postGenerateSchemaTable()null => true in CreateSchemaListener::postGenerateSchemaTable()
phansys
force-pushed
the
ticket_318
branch
2 times, most recently
from
339b48b
to
1f8c9cc
Compare
phansys
changed the title
null => true in CreateSchemaListener::postGenerateSchemaTable()null => true in CreateSchemaListener::postGenerateSchemaTable()
|
Changed base to |
phansys
changed the title
null => true in CreateSchemaListener::postGenerateSchemaTable()null => true in CreateSchemaListener::postGenerateSchemaTable()
phansys
force-pushed
the
ticket_318
branch
4 times, most recently
from
d64ceed
to
f269c48
Compare
phansys
changed the title
null => true in CreateSchemaListener::postGenerateSchemaTable()null => true in CreateSchemaListener::postGenerateSchemaTable()
phansys
changed the title
null => true in CreateSchemaListener::postGenerateSchemaTable()
axzx
reviewed
Apr 9, 2018
| @@ -23,6 +23,7 @@ | |||
| "fabpot/php-cs-fixer": "^1.11" | |||
| }, | |||
| "conflict": { | |||
| "doctrine/dbal": "2.7.0", | |||
There was a problem hiding this comment.
Release 2.7.1 should fix the issue. Could you confirm you're experiencing it with that version?
There was a problem hiding this comment.
OK, I'm sorry.
I thought that from 2.7.0 is this problem.
|
great, thanks! |
|
hmm, did I mess up? I will take a look ... |
|
hmm, lgtm https://github.com/simplethings/EntityAuditBundle/blob/v1.0.9/composer.json#L26 or am I missing something? |
|
@phansys d'oh - you used short array syntax in your test 😄 https://travis-ci.org/simplethings/EntityAuditBundle/jobs/364493226 |
|
Tests for 5.3 weren't running 😇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Fixes #318.