Fix connection for doctrine event tag

[wbloszyk]

Subject

After #355 I got some errors like:

The Doctrine connection "%simplethings.entityaudit.connection%" referenced   
!!    in service "simplethings_entityaudit.log_revisions_listener" does not exist  
!!    . Available connections names: "default".   

It look like doctrine event tag will not convert parameter name into value. This PR will replace this parameter name into value.

I am targeting this branch, because this change respect BC.

Changelog is not needed becouse we do not release #355 yet.

[wbloszyk]

@phansys
I check in my project and it is working. Anyway I can not fix tests. Can you look at this?

[phansys]

@phansys
I check in my project and it is working. Anyway I can not fix tests. Can you look at this?

Sure, I'll try to check this later.

[phansys]

I think this is working, at least in the test environment: wbloszyk#1.
Please, confirm if you can check these changes in a working project.

[wbloszyk]

I think this is working, at least in the test environment: wbloszyk#1.
Please, confirm if you can check these changes in a working project.

@phansys
Parameter will be always the same simplethings.entityaudit.connection. We do not have to check it, becouse it is set in load().

[phansys]

IMO, if we harcode the parameter name here, we are making less flexible the replacing mechanism.
If in the future the parameter name used in these tags is renamed, we must replace this occurrence too.
I also think that the final users could not override these services if they need to use a different value.

[wbloszyk]

We set this simplethings.entityaudit.connection parameter in the same SimpleThingsEntiyAuditExtension, so I think we do not have to afriaid about rename. Additionaly if users override this service then connection name must be set directly, oherwise expection will be throw.

We can also move it to the compiler pass. Then we can check whole services tagged by doctrine.event_listener and replace simplethings.entityaudit.connection parameter in connetion to propertly value.

[wbloszyk]

symfony/symfony#40262
WDYT? @sonata-project/contributors

[VincentLanglet]

I'm not sure to understand, should we wait for symfony/symfony#40262 or can we merge this ?

[wbloszyk]

We can merge this now. This code allow use param only for ower services.we can remove this code when symfony accept it and we bump doctrine-bridge.

Also they can accept it as feature and merge it in 5.2 version.