Make explicit some missing deps

[phansys]

Subject

Make explicit some missing deps.

I am targeting this branch, because these changes respect BC.

Changelog

### Fixed
- Missing dependencies required by this package.

[VincentLanglet]

Why this removal ?

[phansys]

Class Controller was removed in symfony/framework-bundle:5.x:

EntityAuditBundle/src/Controller/AuditController.php

Lines 23 to 37 in af61a7b

	use Symfony\Bundle\FrameworkBundle\Controller\Controller;
	use Symfony\Component\HttpFoundation\Request;
	use Symfony\Component\HttpFoundation\Response;
	use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
	/**
	* Controller for listing auditing information.
	*
	* @author Tim Nagel <[email protected]>
	*
	* @deprecated since sonata-project/entity-audit-bundle 1.1, will be remove in 2.0.
	*
	* NEXT_MAJOR: remove this controller
	*/
	class AuditController extends Controller

[SonataCI]

Could you please rebase your PR and fix merge conflicts?

[phansys]

As stated in the checks for this PR, this package is not compatible with symfony/symfony:"5.3.*" and symfony/symfony:"6.0.*".
IMO, we should try to provide forward compatible bridges or mark these builds as optional.
WDYT?

[jordisala1991]

As stated in the checks for this PR, this package is not compatible with symfony/symfony:"5.3.*" and symfony/symfony:"6.0.*". IMO, we should try to provide forward compatible bridges or mark these builds as optional. WDYT?

I would remove symfony/framework as a dev dependency and instead add it as an extra build (with the variant thing). And ignore the errors of static analysis tools. the class is deprecated and is not suposed to be used or modified anymore, so not a big deal if it is ignored by the tools. wdyt?

[jordisala1991]

why this as require dependency?

[phansys]

Because this package is a Symfony bundle:

EntityAuditBundle/src/SimpleThingsEntityAuditBundle.php

Lines 14 to 20 in 5a442d2

	namespace SimpleThings\EntityAudit;
	use Symfony\Component\HttpKernel\Bundle\Bundle;
	class SimpleThingsEntityAuditBundle extends Bundle
	{
	}

[jordisala1991]

Then dependency injection should be moved to, right?

[phansys]

I would remove symfony/framework as a dev dependency and instead add it as an extra build (with the variant thing). And ignore the errors of static analysis tools. the class is deprecated and is not suposed to be used or modified anymore, so not a big deal if it is ignored by the tools. wdyt?

I agree.

[jordisala1991]

We need the dev-kit PR to add the variant thing, and IMO we should move dependency injection to require section. Other than that looks great

[jordisala1991]

imo we should make explicit the 4.4 version

[phansys]

Done.

[VincentLanglet]

Thanks @phansys