Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make explicit some missing deps #415

Merged
merged 1 commit into from
Oct 25, 2021
Merged

Make explicit some missing deps #415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,10 @@ jobs:
allowed-to-fail: false
symfony-require: 6.0.*
variant: symfony/symfony:"6.0.*"
- php-version: '8.0'
dependencies: highest
allowed-to-fail: false
variant: symfony/framework-bundle:"4.4.*"

steps:
- name: Checkout
Expand Down
13 changes: 6 additions & 7 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,15 @@
"require": {
"php": "^7.3 || ^8.0",
"doctrine/collections": "^1.6",
"doctrine/common": "^3.0",
"doctrine/common": "^3.1",
"doctrine/dbal": "^2.13 || ^3.0",
"doctrine/event-manager": "^1.1",
"doctrine/orm": "^2.10",
"doctrine/persistence": "^2.0",
"doctrine/persistence": "^2.2",
"symfony/config": "^4.4 || ^5.3 || ^6.0",
"symfony/dependency-injection": "^4.4 || ^5.3 || ^6.0",
"symfony/http-kernel": "^4.4 || ^5.3 || ^6.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this as require dependency?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this package is a Symfony bundle:

EntityAuditBundle/src/SimpleThingsEntityAuditBundle.php

Lines 14 to 20 in 5a442d2

namespace SimpleThings\EntityAudit;
use Symfony\Component\HttpKernel\Bundle\Bundle;
class SimpleThingsEntityAuditBundle extends Bundle
{
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then dependency injection should be moved to, right?

"symfony/security-core": "^4.4 || ^5.3 || ^6.0",
"twig/twig": "^2.6 || ^3.0"
},
"conflict": {
Expand All @@ -30,12 +33,8 @@
"matthiasnoback/symfony-dependency-injection-test": "^4.2.1",
"phpunit/phpunit": "^9.5",
"symfony/cache": "^4.4 || ^5.3 || ^6.0",
"symfony/dependency-injection": "^4.4 || ^5.3 || ^6.0",
"symfony/framework-bundle": "^4.4 || ^5.3 || ^6.0",
"symfony/http-foundation": "^4.4 || ^5.3 || ^6.0",
"symfony/http-kernel": "^4.4 || ^5.3 || ^6.0",
"symfony/phpunit-bridge": "^5.3 || ^6.0",
"symfony/security-core": "^4.4 || ^5.3 || ^6.0"
"symfony/phpunit-bridge": "^5.3 || ^6.0"
},
"config": {
"sort-packages": true
Expand Down