-
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DevKit updates for 1.x branch #468
Conversation
fe86216
to
9e4ac01
Compare
9e4ac01
to
c2a75b3
Compare
Maybe @phansys can review this changes, I do not know enough of this bundle to be sure if the changes make sense or not. |
It's not needed to understand how this library works. Personnaly I don't. Priori to this change, the But phpstan/psalm were complaining because it was requiring callable which support both array and object even if the callable were only use after object were loaded, so the callable was only used on object. Instead of having both array and object in the same property, I used two different now. is_array($entities[$key]) become isset($loadedEntities[$key]). |
Well, without this explanation it wasnt that easy to understand 😅. Let me check the Pr again. |
src/Collection/AuditedCollection.php
Outdated
* Entity collection. If can be: | ||
* - empty, if the collection has not been initialized yet | ||
* - store entity | ||
* - contain audited entity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this comment is not right anymore? Both properties has the same , but you kinda splitted how the previous property works, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to improve the comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.