Fixed join columns to be converted to the correct type #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, `AuditReader` fails when handling `ToOne` associations with Symfony Uuids as primary keys. This is fixed by converting the join column value with the join column's type as is already done in line 834 for regular fields.
|
The failure in psalm might get solved in #468 |
VincentLanglet
approved these changes
Jan 16, 2022
jordisala1991
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Currently,
AuditReaderfails when handlingToOneassociations with Symfony Uuids as primary keys. This is fixed by converting the join column value with the join column's type as is already done in line 834 for regular fields.I am targeting this branch, because this is a simple patch.
Changelog