Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy internal SQLResultCasing from ORM #491

Merged
merged 1 commit into from
May 19, 2022

Conversation

franmomu
Copy link
Member

Subject

When using the bundle along with symfony error handler the user gets a deprecation warning about using an internal trait:

The "Doctrine\ORM\Internal\SQLResultCasing" trait is considered internal. It may change without further notice. You should not use it from "SimpleThings\EntityAudit\AuditReader".

I've copied the trait to our domain.

I am targeting this branch, because these changes are BC.

Changelog

### Fixed
- Deprecation warning about using `SQLResultCasing` internal trait

@franmomu franmomu added the patch label May 19, 2022
VincentLanglet
VincentLanglet previously approved these changes May 19, 2022
@VincentLanglet
Copy link
Member

phpcsfixer to fix

@VincentLanglet VincentLanglet merged commit 7af1b8b into sonata-project:1.x May 19, 2022
@franmomu franmomu deleted the copy_internal branch May 20, 2022 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants