-
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Doctrine Event manager v2 #541
Allow Doctrine Event manager v2 #541
Conversation
@@ -13,7 +13,7 @@ | |||
"doctrine/collections": "^1.6", | |||
"doctrine/common": "^3.1", | |||
"doctrine/dbal": "^2.13 || ^3.0", | |||
"doctrine/event-manager": "^1.1", | |||
"doctrine/event-manager": "^1.2 || ^2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 1.1 to 1.2 bump is needed in order to be able to have code that is compatible with both v1 and v2 at the same time (the getAllListeners
method call to be more specific).
Thanks ! Do you need a release for this ? |
@VincentLanglet Thanks for the merge. I'm in no hurry for a release for this, though #543 probably warrants a release once it's merged. |
#543 is merged too. I can make a release, unless you have other PR in mind before |
@VincentLanglet I have one more PR in mind, will be sending it in today. |
@VincentLanglet Here it is, even sooner than I expected 😄 |
Subject
I am targeting this branch, because this is a backwards compatible change.
Changelog