Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop doctrine common #554

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Drop doctrine common #554

merged 1 commit into from
Mar 22, 2023

Conversation

jordisala1991
Copy link
Member

@jordisala1991 jordisala1991 commented Mar 22, 2023

Subject

I am targeting this branch, because this is Bc.

Removing doctrine common, even if we still get it as a transitive dep is a good thing. If the project dont use it directly lets remove it, it is kind of being deprecated.

Changelog

### Removed
- Drop doctrine common dependency.

@jordisala1991
Copy link
Member Author

jordisala1991 commented Mar 22, 2023

I have tried a search for doctrine common and didnt found it on the project, there are uses for Collections, Event manager, but thats on other packages.

@VincentLanglet could you do a second check just to be sure?

@phansys
Copy link
Member

phansys commented Mar 22, 2023

use Doctrine\Common\EventSubscriber;

use Doctrine\Common\EventManager;

@jordisala1991
Copy link
Member Author

use Doctrine\Common\EventSubscriber;

use Doctrine\Common\EventManager;

Those are here : https://github.com/doctrine/event-manager/tree/2.0.x/src

And it is already a dep for this package

Copy link
Member

@phansys phansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just confirmed, Doctrine\Common\EventSubscriber and Doctrine\Common\EventManager are provided by doctrine/event-manager.

@VincentLanglet VincentLanglet merged commit cdd8d10 into 1.x Mar 22, 2023
@VincentLanglet VincentLanglet deleted the jordisala1991-patch-1 branch March 22, 2023 10:49
@VincentLanglet
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants