Fix "diff" result for dates and other objects #599
Conversation
befresh-mweimerskirch
changed the title
… currently fail, because the strict comparison is used.
This is necessary because the strict comparison operator (===) will return false if the objects are not the same instance.
befresh-mweimerskirch
force-pushed
the
bugfix/fix-diff-for-dates-and-other-objects
branch
from
1678e06
to
283df18
Compare
There was a problem hiding this comment.
Thank you @befresh-mweimerskirch.
Could you please update the description telling how the method compareObjects() is different from the loose comparison (==) between objects?
| { | ||
| $diff = new ArrayDiff(); | ||
|
|
||
| $dateInstance1 = new \DateTimeImmutable('2014-01-01 00:00:00.000000'); |
There was a problem hiding this comment.
IMO, we should also add a test setting different time zones in the compared objects, in order to expose how the comparison behaves with different time zones using the same UTC offset.
There was a problem hiding this comment.
I'll add that test case on Monday.
If I understood correctly, the compareObject is pretty the same than |
Co-authored-by: Javier Spagnoletti <[email protected]>
Added to the todo section of the PR. I'll do that on Monday.
No. When using the loose comparison operator on objects, the property values are also compared loosely. Imagine a class that has only a property "name". One object with name "TEST" and one object with name "test" as their respective value. Those two instances would be considered equal using the "==" operator. |
|
As promised, I added a test case with two dates that have different timezones. |
|
Thanks |
Subject
This pull request fixes an issue with the ArrayDiff class and consequentially the AuditReader.
AuditReader::diff currently shows dates (instances of DateTime or DateTimeImmutable) as changed even though they are the same.
This issue was introduced when the loose comparator ("==") was changed to the strict comparison ("===") in commit bf02fd4
This PR reverts the old behaviour for objects, while keeping the strict comparison for other types.
I also added tests. Some of the tests fail without the change, so I hope this illustrates the issue.
I am targeting this branch, because this is a fix that restores previous behaviour (and slightly improves it).
Changelog