Skip to content
This repository has been archived by the owner on Jul 28, 2022. It is now read-only.

Add initial Docker configuration #628

Merged
merged 1 commit into from
Jul 25, 2020
Merged

Add initial Docker configuration #628

merged 1 commit into from
Jul 25, 2020

Conversation

jordisala1991
Copy link
Member

No description provided.

@jordisala1991
Copy link
Member Author

There are a lot of tests failing. This is WIP

@jordisala1991 jordisala1991 marked this pull request as draft July 5, 2020 08:35
phansys
phansys approved these changes Jul 10, 2020
View reviewed changes
Copy link
Member

@phansys phansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be a great addition! 🚀

docker-compose.yaml Outdated Show resolved Hide resolved
.docker/app/Dockerfile Outdated Show resolved Hide resolved
@jordisala1991
Copy link
Member Author

I think test failure is not related to this bundle. There are a lot of work to do in other bundles like SonataCache..

@jordisala1991 jordisala1991 marked this pull request as ready for review July 12, 2020 09:41
@jordisala1991 jordisala1991 requested a review from a team July 12, 2020 09:42
greg0ire
greg0ire reviewed Jul 12, 2020
View reviewed changes
.docker/app/extra.ini Outdated Show resolved Hide resolved
.docker/app/Dockerfile Show resolved Hide resolved
@SonataCI
Copy link
Collaborator

Could you please rebase your PR and fix merge conflicts?

@wbloszyk wbloszyk mentioned this pull request Jul 18, 2020
Closed
22 tasks
@jordisala1991 jordisala1991 requested a review from a team July 19, 2020 07:13
@jordisala1991
Copy link
Member Author

I think we should merge this one to start having a unified environment.

@greg0ire greg0ire merged commit c8d8a03 into sonata-project:master Jul 25, 2020
@greg0ire
Copy link
Contributor

Thanks @jordisala1991 !

@jordisala1991 jordisala1991 deleted the feature/docker branch July 25, 2020 09:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@phansys phansys phansys approved these changes

@greg0ire greg0ire greg0ire approved these changes

@VincentLanglet VincentLanglet VincentLanglet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jordisala1991 @SonataCI @greg0ire @phansys @VincentLanglet