Skip to content
This repository has been archived by the owner on Jul 28, 2022. It is now read-only.

Add symfony/webpack-encore-bundle #630

Merged
merged 1 commit into from
Aug 28, 2020
Merged

Conversation

wbloszyk
Copy link
Member

@wbloszyk wbloszyk commented Jul 10, 2020

This PR will add webpack to sandbox, create some builds and add example build for sonata_admin (adminlte2).

Part of sonata-project/dev-kit#779

@wbloszyk wbloszyk force-pushed the webpack branch 2 times, most recently from 53f5216 to efaf91c Compare July 10, 2020 12:26
CONTRIBUTING_WEBPACK.md Outdated Show resolved Hide resolved
CONTRIBUTING_WEBPACK.md Outdated Show resolved Hide resolved
CONTRIBUTING_WEBPACK.md Outdated Show resolved Hide resolved
CONTRIBUTING_WEBPACK.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@wbloszyk
Copy link
Member Author

@phansys this file should not be change here. I will open new PR in master branch for that.

@wbloszyk wbloszyk requested a review from phansys July 10, 2020 13:56
@jordisala1991
Copy link
Member

Not sure if this is what I thought of building the assets myself (same system as Sylius). On Sylius you dont have to create the js or css on your project, they are already on the downloaded composer files (vendor) you just have an main entry points and then you add them on your webpack config

@jordisala1991
Copy link
Member

You can see it on: https://github.com/Sylius/Sylius-Standard

This sylius standard is something like our sandbox (everything installed and configured, ready to start a project)

@wbloszyk
Copy link
Member Author

@jordisala1991 I know this it not what you mean. This will be done at final changes. For now concept is this branch is little diffrence:

People(contributors) can create own templates based on webpack build. For example I will do it for bootstrap4 and adminlte3.I will push templates to templates/bootstrap4 directory and webpack config to builds_configs/sonata_admin_adminlte3. Other contributors can check my work by run yarn encore dev on choosen config and by move templates to templates/bundle.

When some templates will be done, then we can split it to bundles and add webpack config as you wrote. At first we need working templates :)

@wbloszyk wbloszyk force-pushed the webpack branch 2 times, most recently from 88163f2 to 4eb7e0a Compare July 17, 2020 08:47
name: Lint

jobs:
php-cs-fixer:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SonataCI
Copy link
Collaborator

Could you please rebase your PR and fix merge conflicts?

Update CONTRIBUTING_WEBPACK.md

Co-authored-by: Javier Spagnoletti <[email protected]>

Update CONTRIBUTING_WEBPACK.md

Co-authored-by: Javier Spagnoletti <[email protected]>

Update CONTRIBUTING_WEBPACK.md

Co-authored-by: Javier Spagnoletti <[email protected]>

Update CONTRIBUTING_WEBPACK.md

Co-authored-by: Javier Spagnoletti <[email protected]>
@wbloszyk wbloszyk merged commit a61ab59 into sonata-project:webpack Aug 28, 2020
@wbloszyk wbloszyk deleted the webpack branch September 14, 2020 17:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants