-
-
Notifications
You must be signed in to change notification settings - Fork 198
Conversation
53f5216
to
efaf91c
Compare
@phansys this file should not be change here. I will open new PR in master branch for that. |
Not sure if this is what I thought of building the assets myself (same system as Sylius). On Sylius you dont have to create the js or css on your project, they are already on the downloaded composer files (vendor) you just have an main entry points and then you add them on your webpack config |
You can see it on: https://github.com/Sylius/Sylius-Standard This sylius standard is something like our sandbox (everything installed and configured, ready to start a project) |
@jordisala1991 I know this it not what you mean. This will be done at final changes. For now concept is this branch is little diffrence: People(contributors) can create own templates based on webpack build. For example I will do it for bootstrap4 and adminlte3.I will push templates to When some templates will be done, then we can split it to bundles and add webpack config as you wrote. At first we need working templates :) |
88163f2
to
4eb7e0a
Compare
.github/workflows/lint.yaml
Outdated
name: Lint | ||
|
||
jobs: | ||
php-cs-fixer: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can also add a new task to check if the assets can be build: https://github.com/nucleos/NucleosMapsBundle/blob/main/.github/workflows/continuous-integration.yml#L14-L31
Could you please rebase your PR and fix merge conflicts? |
201cc29
to
b10aebe
Compare
Update CONTRIBUTING_WEBPACK.md Co-authored-by: Javier Spagnoletti <[email protected]> Update CONTRIBUTING_WEBPACK.md Co-authored-by: Javier Spagnoletti <[email protected]> Update CONTRIBUTING_WEBPACK.md Co-authored-by: Javier Spagnoletti <[email protected]> Update CONTRIBUTING_WEBPACK.md Co-authored-by: Javier Spagnoletti <[email protected]>
This PR will add webpack to sandbox, create some builds and add example build for sonata_admin (adminlte2).
Part of sonata-project/dev-kit#779