Skip to content
This repository has been archived by the owner on Jul 28, 2022. It is now read-only.

Add static code analysis through GitHub actions #632

Merged
merged 1 commit into from
Jul 16, 2020

Conversation

phansys
Copy link
Member

@phansys phansys commented Jul 12, 2020

IMO, we are able to configure this project at "dev-kit".

@phansys phansys requested a review from a team July 12, 2020 23:41
@phansys
Copy link
Member Author

phansys commented Jul 14, 2020

IMO, the fixes are RTM. We must decide what to do with the workflow configuration.

@phansys phansys marked this pull request as ready for review July 14, 2020 18:51
@phansys phansys changed the title [PoC] Add static code analysis through GitHub actions Add static code analysis through GitHub actions Jul 14, 2020
@SonataCI
Copy link
Collaborator

Could you please rebase your PR and fix merge conflicts?

@phansys
Copy link
Member Author

phansys commented Jul 15, 2020

These are the analysis results In my fork: https://github.com/phansys/sandbox/actions.

@jordisala1991
Copy link
Member

Can you check phpstan failures?

@phansys
Copy link
Member Author

phansys commented Jul 16, 2020

Can you check phpstan failures?

Sure! They are now fixed 👍

@wbloszyk wbloszyk mentioned this pull request Jul 16, 2020
22 tasks
@jordisala1991 jordisala1991 merged commit 97bf3bd into sonata-project:master Jul 16, 2020
@jordisala1991
Copy link
Member

Thank you @phansys

@phansys phansys deleted the sca branch July 16, 2020 19:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants