This repository has been archived by the owner on Jul 28, 2022. It is now read-only.
Improve fixtures 2 #633
Merged
Improve fixtures 2 #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbloszyk
force-pushed
the
improve_fixtures_2
branch
from
36c1243
to
32c457c
Compare
src/Sonata/Bundle/DemoBundle/DataFixtures/ORM/LoadCategoryData.php
Outdated
Show resolved
Hide resolved
wbloszyk
force-pushed
the
improve_fixtures_2
branch
from
32c457c
to
2572070
Compare
wbloszyk
force-pushed
the
improve_fixtures_2
branch
from
2572070
to
1334720
Compare
src/Sonata/Bundle/DemoBundle/DataFixtures/ORM/LoadContextData.php
Outdated
Show resolved
Hide resolved
wbloszyk
force-pushed
the
improve_fixtures_2
branch
from
1334720
to
488cead
Compare
jordisala1991
approved these changes
Jul 18, 2020
| @@ -13,6 +13,7 @@ | |||
|
|
|||
| namespace AppBundle\Entity\Classification; | |||
|
|
|||
| use Doctrine\Common\Collections\ArrayCollection; | |||
There was a problem hiding this comment.
Isn't better to use Collection for typehint ?
| @@ -13,6 +13,7 @@ | |||
|
|
|||
| namespace AppBundle\Entity\Classification; | |||
|
|
|||
| use Doctrine\Common\Collections\ArrayCollection; | |||
| use Sonata\ClassificationBundle\Entity\BaseCollection; | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Not sure we should keep the comment
There was a problem hiding this comment.
Lets ignore it in this PR. Some pedantic and use best symfony practices is require anyway and this can be done there.
VincentLanglet
approved these changes
Jul 18, 2020
|
Thank you @wbloszyk |
20 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add type hints and move repeatable code parts to methods.