Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nvgre parsing #406

Closed
budgrise opened this issue Jul 24, 2023 · 6 comments
Closed

nvgre parsing #406

budgrise opened this issue Jul 24, 2023 · 6 comments
Assignees

Comments

@budgrise
Copy link
Collaborator

Nvgre output was added by PR #308 Add ST route type.
Is there also a requirement for parsing incoming nvgre packets?

@KrisNey-MSFT
Copy link
Collaborator

No support for packets coming to the pipeline, they can only go out.
No use for it right now (no implementation for nvgre on ingress), but may be in the future, and we would need to add the code.
Assumption is that 2 DASH devices would not communicate using nvgre.
ST is a tunnel towards a public IP (on the Internet). Do packets return on nvgre? Ask @prsunny

@KrisNey-MSFT
Copy link
Collaborator

Reminder of this question @prsunny or @r12f or @kperumalbfn

ST is a tunnel towards a public IP (on the Internet). Do packets return on nvgre?

@KrisNey-MSFT
Copy link
Collaborator

Added @pranjal-git in case he may know

@r12f
Copy link
Collaborator

r12f commented Oct 4, 2023

Hi @budgrise, on high level, the packet transformation will still follow this doc: https://github.com/sonic-net/DASH/blob/main/documentation/general/sdn-pipeline-basic-elements.md#service-tunneling, and I am sure you are already aware of it:

In my understanding, the return packet will rely on reverse flow to do the transformation:

  • The return packet will have 2 layers of encaps, which will be all decap'ed before sending to the pipeline. However, this is not modeled today in DASH and our BM, but this is what should be happening.
  • After decap, the flow matching will only use the 5 tuples from the inner most packet. This will find the reverse flow and apply the transformations.

@r12f
Copy link
Collaborator

r12f commented Oct 9, 2023

Hi Bud, I have updated the proposal for making this behavior clarified as well as addressing certain future cases. Please feel free to take a look and let me know what you think: https://github.com/r12f/DASH/blob/user/r12f/pipeline/documentation/general/dash-sai-pipeline-packet-flow.md#54-packet-decap.

The PR can also be found here: #449. Feel free to leave me comments as well! :D

@KrisNey-MSFT
Copy link
Collaborator

Closing in favor of PR449 per Community Call

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants