From 8d9effc4971d33763f61cb12c995be3af9ac0a8c Mon Sep 17 00:00:00 2001 From: vedganes Date: Tue, 2 Feb 2021 11:08:43 -0500 Subject: [PATCH] [systemport]System port pvid setting error fix Signed-off-by: vedganes While adding system port as member for a system port channel, pvid is set. Since pvid setting is not applicable for systemports in remote asics, SAI returns faiure. This results in display of error. setPortPvid() api is modified to skip setting the pvid for system ports and an INFO is displayed. --- orchagent/portsorch.cpp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/orchagent/portsorch.cpp b/orchagent/portsorch.cpp index 35974e7af9..03735e52f3 100755 --- a/orchagent/portsorch.cpp +++ b/orchagent/portsorch.cpp @@ -1380,6 +1380,12 @@ bool PortsOrch::setPortPvid(Port &port, sai_uint32_t pvid) return true; } + if(port.m_type == Port::SYSTEM) + { + SWSS_LOG_INFO("pvid setting for system port %s is not applicable", port.m_alias.c_str()); + return true; + } + if (port.m_rif_id) { SWSS_LOG_ERROR("pvid setting for router interface %s is not allowed", port.m_alias.c_str());