Bug: Bridge port remove error "None"

[antony-rheneus]

https://github.com/Azure/sonic-swss/blob/ebb5324ddfdefd6ebcd38937856e5bebc7be4f60/cfgmgr/vlanmgr.cpp#L184

Bug: bridge vlan command doesn't print "None", so it will fail for VLan member ports as well non-Vlan member ports

There is NO 'None' printed in below bridge command
root@et6448m-M0:/home/admin# /sbin/bridge vlan show dev Ethernet17
port    vlan ids



root@et6448m-M0:/home/admin# config vlan member add 500 Ethernet17 -u
root@et6448m-M0:/home/admin# /sbin/bridge vlan show dev Ethernet17
port    vlan ids
Ethernet17       1 Egress Untagged
         500 PVID Egress Untagged

[stcheng]

@jipanyang

[jipanyang]

Looks like the same problem as sonic-net/sonic-buildimage#2658

Could take this fix:

 ''bridge vlan del vid 1 dev {{ port }}" should be called immediately after "ip link set dev {{ port }} master Bridge" the first time.

[antony-rheneus]

Looks like the same problem as Azure/sonic-buildimage#2658

Could take this fix:

 ''bridge vlan del vid 1 dev {{ port }}" should be called immediately after "ip link set dev {{ port }} master Bridge" the first time.

I think right fix is to add Port_alias instead of None.
GREP_CMD + " -q " + port_alias "&& "

[jipanyang]

[email protected]:~# bridge vlan show dev PortChannel8
port	vlan ids
PortChannel8	 10 PVID Egress Untagged

Once a vlan member is out of default vlan 1, and is not in any other vlan .

[email protected]:~# bridge vlan del vid 10 dev PortChannel8
[email protected]:~# 
[email protected]:~# bridge vlan show dev PortChannel8
port	vlan ids
PortChannel8	None

config vlan member del command has issue currently, it assumes the existence of members field in vlan table(sonic-net/SONiC#323). But the fix in #1001 is necessary.