Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy updates, README, 1 minute expiration #95

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

AdrianCann
Copy link
Collaborator

Copy text

  • The feature recently added required additional copy text. Also, the
    README now mentions this feature

1 Minute

  • A new, shorter duration option is added (1 minute). Since the note can
    be viewed multiple times, it seems like it would be fun to set a really
    short duration on when it can be viewed. One could post it to a chat
    channel, or text thread, and force everybody to view it quickly.

***Copy text***
* The feature recently added required additional copy text. Also, the
README now mentions this feature

***1 Minute***
* A new, shorter duration option is added (1 minute). Since the note can
be viewed multiple times, it seems like it would be fun to set a really
short duration on when it can be viewed. One could post it to a chat
channel, or text thread, and force everybody to view it quickly.
@AdrianCann
Copy link
Collaborator Author

For the sake of short duration notes, a box could be included (and copyable) on the sucess.html.erb page that has instructions. These instructions would say something like:

Here is a onetime note.
This note can be viewed only once. Once you (or someone else) has followed the link the note will disappear.
The note cannot be viewed after 30 days.

or

Here is a onetime note.
This note can be by you or anyone for the next 1 minute.
The note cannot be viewed after 30 days.


describe "#sendable_message" do
it 'says' do

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body beginning.

@@ -20,4 +20,10 @@
expect(page_presenter.optional_fields_state).to eq("")
end
end

describe "#sendable_message" do
it 'says' do

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

# Settings in config/environments/* take precedence over those specified here.
# Application configuration should go into files in config/initializers
# -- all .rb files in that directory are automatically loaded.

# Set Time.zone default to the specified zone and make Active Record auto-convert to this zone.
# Run "rake -D time" for a list of tasks for finding time zone names. Default is UTC.
# config.time_zone = 'Central Time (US & Canada)'
config.time_zone = 'Eastern Time (US & Canada)'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

@@ -30,13 +30,16 @@ class Application < Rails::Application
end

config.action_controller.action_on_unpermitted_parameters = :raise
Rails.application.routes.default_url_options[:host] = ENV.fetch('HOST')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

message += ")"
message += " It can only be viewed once." unless multiview?
message += " "
message += link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint/UselessAssignment: Useless assignment to variable - message. Use + instead of +=.

message += " that expires in #{time_until_expiration}"
message += " ("
message += "#{expires_at.in_time_zone.strftime("%m/%d/%Y")}"
message += " at #{expires_at.in_time_zone.strftime("%I:%M%p %Z")}."

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/StringLiteralsInInterpolation: Prefer single-quoted strings inside interpolations.

message = "Here is a link to a onetime note"
message += " that expires in #{time_until_expiration}"
message += " ("
message += "#{expires_at.in_time_zone.strftime("%m/%d/%Y")}"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/UnneededInterpolation: Prefer to_s over string interpolation.
Style/StringLiteralsInInterpolation: Prefer single-quoted strings inside interpolations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants