Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add computed MSID to return Quat for quaternion MSID sets #233

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

taldcroft
Copy link
Member

Description

This adds a convenience interface to allow getting Quat objects for spacecraft telemetry directly from the cheta archive.

This defines the following computed MSIDs based on the corresponding TDB MSIDs:

  • quat_aoattqt = AOATTQT[1-4]
  • quat_aoatupq = AOATUPQ[1-3]
  • quat_aocmdqt = AOCMDQT[1-3]
  • quat_aotarqt = AOTARQT[1-3]

Interface impacts

None

Testing

Unit tests

  • Mac (with new unit tests)

Independent check of unit tests by [REVIEWER NAME]

  • [PLATFORM]:

Functional tests

No functional testing.

Copy link
Contributor

@javierggt javierggt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. I looked at the code and ran the tests on HEAD. The tests seem to check the right thing.

I would note that in general this might require the improved normalize function in Quaternion, and this is not tested.

@taldcroft
Copy link
Member Author

Yeah, testing for bad quats in telemetry might be a good thing, but it should just work. Since this functionality is already a little obscure and in the interest of keeping things moving I'm just merging.

@taldcroft taldcroft merged commit 938505b into master Jul 7, 2022
@taldcroft taldcroft deleted the quat-msid-comp branch July 7, 2022 17:29
@javierggt javierggt mentioned this pull request Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants