Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chore): remove support for node v14,v12,v10 #111

Merged
merged 1 commit into from
May 11, 2023
Merged

Conversation

RaghavaroraSF
Copy link
Contributor

@RaghavaroraSF RaghavaroraSF commented May 4, 2023

Description

  • Version 14, v12, v10 of Nodejs reached its end of life

  • BREAKING CHANGE:
    End of life of node v14, node v12 and node v10

GH-110

Fixes #110

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

@yeshamavani
Copy link
Contributor

in the repo there as .d.ts and .js index files present
they are redundant, please remove those files

Version 14, v12, v10 of Nodejs reached its end of life

BREAKING CHANGE:
End of life of node v14, node v12 and node v10

GH-110
@RaghavaroraSF RaghavaroraSF changed the title feat(chore): add support for node v18 feat(chore): remove support for node v14,v12,v10 May 9, 2023
Copy link
Contributor

@yeshamavani yeshamavani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this marked as feature, no new feature is being introduced

@yeshamavani
Copy link
Contributor

After referring loopback decided to go in with feature type

@yeshamavani yeshamavani merged commit 8a00196 into master May 11, 2023
@yeshamavani yeshamavani deleted the GH-110 branch May 11, 2023 05:14
@shubhamp-sf
Copy link
Contributor

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support for node v14
3 participants