Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Wait between P2P update retry attempts #1052

Merged
merged 1 commit into from
Jan 20, 2023
Merged

test: Wait between P2P update retry attempts #1052

merged 1 commit into from
Jan 20, 2023

Conversation

AndrewSisley
Copy link
Contributor

Relevant issue(s)

Resolves #1051

Description

Wait between P2P update retry attempts. A bit ugly, but the retries were still failing sometimes when test execution speed is slow.

@AndrewSisley
Wait between retry attempts
3691611 
A bit ugly, but the retries are still failing sometimes when test execution speed is slow
@AndrewSisley AndrewSisley added bug Something isn't working area/testing Related to any test or testing suite area/p2p Related to the p2p networking system action/no-benchmark Skips the action that runs the benchmark. labels Jan 20, 2023
@AndrewSisley AndrewSisley added this to the DefraDB v0.5 milestone Jan 20, 2023
@AndrewSisley AndrewSisley requested a review from a team January 20, 2023 21:11
@AndrewSisley AndrewSisley self-assigned this Jan 20, 2023
fredcarle
fredcarle approved these changes Jan 20, 2023
View reviewed changes
Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should do!

@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Merging #1052 (3691611) into develop (4e6df91) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1052   +/-   ##
========================================
  Coverage    67.90%   67.90%           
========================================
  Files          171      171           
  Lines        16275    16275           
========================================
  Hits         11052    11052           
  Misses        4298     4298           
  Partials       925      925
Impacted Files Coverage Δ
datastore/badger/v3/datastore.go 39.12% <0.00%> (-0.49%) ⬇️
net/server.go 58.23% <0.00%> (+1.14%) ⬆️

shahzadlone
shahzadlone approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@shahzadlone shahzadlone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndrewSisley AndrewSisley merged commit 2eb7180 into develop Jan 20, 2023
@AndrewSisley AndrewSisley deleted the sisley/fix/I1051-p2p-retry branch January 20, 2023 21:28
shahzadlone pushed a commit that referenced this pull request Apr 13, 2023
@AndrewSisley @shahzadlone
test: Wait between P2P update retry attempts (#1052)
e6babce 
A bit ugly, but the retries are still failing sometimes when test execution speed is slow
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@AndrewSisley
test: Wait between P2P update retry attempts (sourcenetwork#1052)
162c3e1 
A bit ugly, but the retries are still failing sometimes when test execution speed is slow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredcarle fredcarle fredcarle approved these changes

@shahzadlone shahzadlone shahzadlone approved these changes

Assignees

@AndrewSisley AndrewSisley

Labels
action/no-benchmark Skips the action that runs the benchmark. area/p2p Related to the p2p networking system area/testing Related to any test or testing suite bug Something isn't working
Projects
None yet
Milestone
DefraDB v0.5
Development

Successfully merging this pull request may close these issues.

New P2P tests are flaky
3 participants
@AndrewSisley @fredcarle @shahzadlone