feat: Add schema version id to commit queries #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
feature
AndrewSisley
force-pushed
the
sisley/feat/I1006-schema-version-commit-2
branch
from
6b75761
to
79ad6f0
Compare
Spotted whilst looking for a type, this variable is no longer used and can be removed
Will be added to shortly
Codecov Report
@@ Coverage Diff @@
## develop #1061 +/- ##
===========================================
+ Coverage 68.19% 68.21% +0.01%
===========================================
Files 173 173
Lines 16330 16338 +8
===========================================
+ Hits 11137 11145 +8
Misses 4261 4261
Partials 932 932
|
AndrewSisley
force-pushed
the
sisley/feat/I1006-schema-version-commit-2
branch
from
79ad6f0
to
3fa9e4f
Compare
fredcarle
approved these changes
Jan 31, 2023
Comment on lines
+60
to
+64
| SchemaVersionID string | ||
| Priority uint64 | ||
| Data []byte | ||
| DocKey []byte | ||
| }{delta.SchemaVersionID, delta.Priority, delta.Data, delta.DocKey}) |
There was a problem hiding this comment.
suggestion: Since the struct represents the LWWRegDelta struct, you could probably just use
LWWRegDelta{delta.SchemaVersionID, delta.Priority, delta.Data, delta.DocKey}
There was a problem hiding this comment.
Discussed a bit in the standup - this comment prompted the creation of #1065. In the short term I'll leave this as is, as it is not new and can be sorted out better if done in a dedicated yet broader ticket.
shahzadlone
pushed a commit
that referenced
this pull request
Apr 13, 2023
* Remove deadcode Spotted whilst looking for a type, this variable is no longer used and can be removed * Break up long line Will be added to shortly * Persist schemaVersionId on field commits * Add SchemaVersionId to commit query
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
* Remove deadcode Spotted whilst looking for a type, this variable is no longer used and can be removed * Break up long line Will be added to shortly * Persist schemaVersionId on field commits * Add SchemaVersionId to commit query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #1006
Description
Adds schema version id to commit queries.
Also persists schema version id on field commit blocks as discussed earlier - this is because it is quite difficult to find the composite commit from the field commit, as well as being a little strange ideologically. In the future we may break this property out to a new index/key to save space/duplication, but not now.