Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for schema version id in queries #1067

Merged

Conversation

AndrewSisley
Copy link
Contributor

Relevant issue(s)

Resolves #1008

Description

Adds support for schema version id in queries.

This was actually accidentally added in #1061 as I forgot that the gql type of the _version property was the commit object type - this PR just adds tests for this.

@AndrewSisley AndrewSisley added feature New feature or request area/query Related to the query component area/schema Related to the schema system action/no-benchmark Skips the action that runs the benchmark. labels Jan 31, 2023
@AndrewSisley AndrewSisley added this to the DefraDB v0.5 milestone Jan 31, 2023
@AndrewSisley AndrewSisley requested a review from a team January 31, 2023 22:35
@AndrewSisley AndrewSisley self-assigned this Jan 31, 2023
@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #1067 (2ce802a) into develop (a4c6869) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1067      +/-   ##
===========================================
+ Coverage    68.14%   68.19%   +0.05%     
===========================================
  Files          173      173              
  Lines        16338    16338              
===========================================
+ Hits         11133    11142       +9     
+ Misses        4271     4263       -8     
+ Partials       934      933       -1     
Impacted Files Coverage Δ
planner/select.go 80.60% <0.00%> (+3.42%) ⬆️

Copy link
Member

@shahzadlone shahzadlone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some style / formatting suggestion.

@AndrewSisley AndrewSisley merged commit 97b5300 into develop Feb 1, 2023
@AndrewSisley AndrewSisley deleted the sisley/feat/I1008-time-travel-schema-version-id branch February 1, 2023 00:29
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/no-benchmark Skips the action that runs the benchmark. area/query Related to the query component area/schema Related to the schema system feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add schema version identifier field to time-travelling queries
2 participants