Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Add workflow that runs a given task on AWS EC2 container. #110

Merged
merged 11 commits into from
Jan 14, 2022
Merged

ci: Add workflow that runs a given task on AWS EC2 container. #110

merged 11 commits into from
Jan 14, 2022

Conversation

shahzadlone
Copy link
Member

TODO: fill in the new information of the new Subnet and new VPC with their security group, and then test the bench marking runs properly on the EC2 instance.

@shahzadlone shahzadlone marked this pull request as ready for review January 13, 2022 22:25
@shahzadlone shahzadlone self-assigned this Jan 13, 2022
@shahzadlone
Copy link
Member Author

@jsimnz This is ready to merge, we can replace the filler echo command with the bench marking steps once it's ready.

jsimnz
jsimnz approved these changes Jan 14, 2022
View reviewed changes
Copy link
Member

@jsimnz jsimnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsimnz jsimnz self-requested a review January 14, 2022 05:21
jsimnz
jsimnz requested changes Jan 14, 2022
View reviewed changes
Copy link
Member

@jsimnz jsimnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change name (and filename) of the workflow to benchmark-runner-ec2 or something. Other than that, looks good

@codecov
Copy link

codecov bot commented Jan 14, 2022 •
edited
Loading

Codecov Report

Merging #110 (0afd2d2) into develop (06e4a0a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #110   +/-   ##
========================================
  Coverage    54.32%   54.32%           
========================================
  Files           44       44           
  Lines         3650     3650           
========================================
  Hits          1983     1983           
  Misses        1439     1439           
  Partials       228      228
Flag Coverage Δ
unittests 54.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06e4a0a...0afd2d2. Read the comment docs.

@shahzadlone shahzadlone changed the title ci: Setup workflow that runs a given task on AWS EC2 container. ci: Add workflow that runs a given task on AWS EC2 container. Jan 14, 2022
@shahzadlone shahzadlone merged commit 3618d9f into develop Jan 14, 2022
@shahzadlone shahzadlone deleted the lone/ci/github-workflow-aws-ec2-for-benchmarks branch January 14, 2022 06:17
@shahzadlone shahzadlone linked an issue Jan 27, 2022 that may be closed by this pull request
Setup dedicated GithubActions worker/runner for benchmark suite #62
Closed
@orpheuslummis orpheuslummis mentioned this pull request Jan 29, 2022
Closed
shahzadlone added a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@shahzadlone
ci: Add workflow that runs a job on AWS EC2 instance. (sourcenetwork#110
7cd6551 
)

Workflow steps that are introduced:
1) Starts an EC2 instance on AWS and registers it as a github runner.
2) Runs the job (todo-job = benchmarks) on the started EC2 instance.
3) Stops / Terminates the EC2 instance that was started and had the job run on.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsimnz jsimnz jsimnz requested changes

Assignees

@shahzadlone shahzadlone

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup dedicated GithubActions worker/runner for benchmark suite
2 participants
@shahzadlone @jsimnz