Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update dependencies including go-ipfs #1112

Merged
merged 5 commits into from
Feb 16, 2023

Conversation

fredcarle
Copy link
Collaborator

Relevant issue(s)

Resolves #451

Description

This PR updates most of our direct dependencies including IPFS packages that impacted the CID creation

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

make test

Specify the platform(s) on which this was tested:

  • MacOS

@fredcarle fredcarle added action/no-benchmark Skips the action that runs the benchmark. dependencies Related to dependencies labels Feb 16, 2023
@fredcarle fredcarle added this to the DefraDB v0.5 milestone Feb 16, 2023
@fredcarle fredcarle requested a review from a team February 16, 2023 19:36
@fredcarle fredcarle self-assigned this Feb 16, 2023
@AndrewSisley
Copy link
Contributor

todo: (I assume this to be the plan, but just in case) - would be very good to note exactly why and how they have changed in the breaking change doc as this is not just a property change on our side (e.g. prop deletion from SchemaDescription).

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #1112 (f8b5de3) into develop (f80d8e1) will not change coverage.
The diff coverage is 100.00%.

❗ Current head f8b5de3 differs from pull request most recent head b76fb06. Consider uploading reports for the commit b76fb06 to get more accurate results

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1112   +/-   ##
========================================
  Coverage    67.73%   67.73%           
========================================
  Files          181      181           
  Lines        16551    16551           
========================================
  Hits         11210    11210           
  Misses        4400     4400           
  Partials       941      941           
Impacted Files Coverage Δ
datastore/blockstore.go 54.94% <ø> (ø)
net/peer.go 46.04% <ø> (ø)
net/process.go 77.96% <ø> (ø)
planner/commit.go 83.52% <ø> (ø)
db/collection_delete.go 29.41% <100.00%> (ø)

Copy link
Contributor

@AndrewSisley AndrewSisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers Fred :)

@fredcarle fredcarle merged commit 1e251d0 into develop Feb 16, 2023
@fredcarle fredcarle deleted the fredcarle/chore/I435-go-ipfs-update branch February 16, 2023 23:17
@orpheuslummis
Copy link
Contributor

Thanks @fredcarle for unblocking the dependency updating with this PR. Fresh air!

shahzadlone pushed a commit that referenced this pull request Apr 13, 2023
Relevant issue(s)
Resolves #451

Description
This PR updates most of our direct dependencies including IPFS packages that impacted the CID creation
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
Relevant issue(s)
Resolves sourcenetwork#451

Description
This PR updates most of our direct dependencies including IPFS packages that impacted the CID creation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/no-benchmark Skips the action that runs the benchmark. dependencies Related to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dependencies handling go-ipfs' breaking transition to raw multihashes in datastores
3 participants