Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update opentelemetry dependencies #1114

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

orpheuslummis
Copy link
Contributor

@orpheuslummis orpheuslummis commented Feb 17, 2023

Relevant issue(s)

Resolves #1113
Last issue of #317 then we can do #320

Description

Update to latest opentelemetry dependencies. It includes handling of breaking changes.

At this point in time, this brings us to having all most-recent direct dependencies.

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

make test

Specify the platform(s) on which this was tested:

  • MacOS

@orpheuslummis orpheuslummis added the action/no-benchmark Skips the action that runs the benchmark. label Feb 17, 2023
@orpheuslummis orpheuslummis self-assigned this Feb 17, 2023
@orpheuslummis orpheuslummis requested review from shahzadlone and a team February 17, 2023 01:58
@orpheuslummis orpheuslummis added this to the DefraDB v0.5 milestone Feb 17, 2023
@orpheuslummis orpheuslummis added the dependencies Related to dependencies label Feb 17, 2023
@orpheuslummis
Copy link
Contributor Author

I'm currently unfamiliar with the actual usage of opentelemetry so your feedback @shahzadlone would be very much appreciated !

@source-devs
Copy link

Benchmark Results

Summary

  • 0 Benchmarks successfully compared.
  • 0 Benchmarks were ✅ Better.
  • 0 Benchmarks were ❌ Worse .
  • 0 Benchmarks were ✨ Unchanged.
✅ See Better Results...
time/opdelta
 
❌ See Worse Results...
time/opdelta
 
✨ See Unchanged Results...
time/opdelta
 
🐋 See Full Results...

@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #1114 (5c728ea) into develop (1e251d0) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1114      +/-   ##
===========================================
+ Coverage    67.73%   67.74%   +0.01%     
===========================================
  Files          181      181              
  Lines        16551    16551              
===========================================
+ Hits         11210    11212       +2     
+ Misses        4400     4399       -1     
+ Partials       941      940       -1     
Impacted Files Coverage Δ
metric/metric.go 65.78% <100.00%> (ø)
connor/lt.go 58.33% <0.00%> (-2.78%) ⬇️
net/server.go 60.84% <0.00%> (+0.97%) ⬆️

Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change Orpheus. I had done it in my PR but then reverted cuz I wasn't sure if Shahzad wanted to make the change yet but I think it makes sense. It's a pretty straight forward change.

@orpheuslummis orpheuslummis merged commit b6f4743 into develop Feb 17, 2023
@orpheuslummis orpheuslummis deleted the orpheus/deps/update-opentelemetry-deps branch February 17, 2023 17:36
@shahzadlone
Copy link
Member

Sorry for the late response @orpheuslummis thought would still let you know it all looks okay 👍

@orpheuslummis
Copy link
Contributor Author

Sorry for the late response @orpheuslummis thought would still let you know it all looks okay 👍

Great. Sorry I forgot you were taking some time off!

shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/no-benchmark Skips the action that runs the benchmark. dependencies Related to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update opentelemetry dependencies
4 participants