Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some thunks in generate.go do not correctly handle errors #112

Closed
AndrewSisley opened this issue Jan 11, 2022 · 0 comments · Fixed by #123
Closed

Some thunks in generate.go do not correctly handle errors #112

AndrewSisley opened this issue Jan 11, 2022 · 0 comments · Fixed by #123
Assignees
@AndrewSisley
Labels
area/schema Related to the schema system bug Something isn't working
Milestone
DefraDB v0.2

Comments

@AndrewSisley
Copy link
Contributor

I only fixed the main field-definition thunk in buildTypesFromAST, there are still other thunks in there that do not handle errors allowing for silent failures.

Likely involves editing the gql fork.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrewSisley AndrewSisley

Labels
area/schema Related to the schema system bug Something isn't working
Projects
None yet
Milestone
DefraDB v0.2
Development

Successfully merging a pull request may close this issue.

fix: Handle errors generated during input object thunks sourcenetwork/defradb
2 participants
@jsimnz @AndrewSisley