Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Correct commits query example in readme #1172

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

AndrewSisley
Copy link
Contributor

Relevant issue(s)

Resolves #1170

Description

Corrects a commits query example in the readme. Spotted whilst looking it over for Pavneet.

Spotted whilst looking it over for Pavneet.
@AndrewSisley AndrewSisley added bug Something isn't working documentation Improvements or additions to documentation action/no-benchmark Skips the action that runs the benchmark. labels Mar 8, 2023
@AndrewSisley AndrewSisley added this to the DefraDB v0.5 milestone Mar 8, 2023
@AndrewSisley AndrewSisley requested a review from a team March 8, 2023 18:32
@AndrewSisley AndrewSisley self-assigned this Mar 8, 2023
Copy link
Contributor

@orpheuslummis orpheuslummis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I wouldn't be surprised if other problems pop-up, but i've made an issue for us/I to verify all in-repo docs are fine for the v0.5 release #1171.

@orpheuslummis
Copy link
Contributor

I recommend using commit title prefix docs

@AndrewSisley AndrewSisley changed the title fix: Correct commits query example in readme docs: Correct commits query example in readme Mar 8, 2023
@AndrewSisley
Copy link
Contributor Author

I recommend using commit title prefix docs

:) I went back and forth between the two lol - changed to docs

@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #1172 (8d332d2) into develop (e5a81c1) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1172      +/-   ##
===========================================
+ Coverage    68.28%   68.34%   +0.06%     
===========================================
  Files          181      181              
  Lines        17007    17007              
===========================================
+ Hits         11613    11624      +11     
+ Misses        4426     4417       -9     
+ Partials       968      966       -2     
Impacted Files Coverage Δ
connor/lt.go 58.33% <0.00%> (-2.78%) ⬇️
net/peer.go 45.59% <0.00%> (+1.68%) ⬆️
net/client.go 85.71% <0.00%> (+7.14%) ⬆️

@AndrewSisley AndrewSisley merged commit 747cf1d into develop Mar 8, 2023
@AndrewSisley AndrewSisley deleted the sisley/docs/I1170-readme-commits branch March 8, 2023 18:53
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/no-benchmark Skips the action that runs the benchmark. bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Defra repo readme contains incorrect commits example
2 participants