fix: Remove new types from in-memory cache on generate error #122

AndrewSisley · 2022-01-18T17:33:34Z

Closes #104

Previously a test would pass if an error was returned due to early exit

Previously they would hang around until database restart - corrupting the schema and preventing schema correction

codecov · 2022-01-18T17:33:51Z

Codecov Report

Merging #122 (978d6a4) into develop (0cd7370) will increase coverage by 0.25%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #122      +/-   ##
===========================================
+ Coverage    54.03%   54.28%   +0.25%     
===========================================
  Files           35       35              
  Lines         3633     3653      +20     
===========================================
+ Hits          1963     1983      +20     
  Misses        1441     1441              
  Partials       229      229

Impacted Files	Coverage Δ
query/graphql/schema/generate.go	`82.02% <100.00%> (+0.69%)`	⬆️
query/graphql/schema/relations.go	`54.63% <0.00%> (ø)`

jsimnz

Great fix. There will def be more to overhaul once schema migrations come in. But for now this looks like it works great. The added failure test to check for invalid states is awesome!

…etwork#122) * Force checking of returned errors in generator tests Previously a test would pass if an error was returned due to early exit * Remove new types from IM cache on generate error Previously they would hang around until database restart - corrupting the schema and preventing schema correction

AndrewSisley added 2 commits January 18, 2022 12:29

Force checking of returned errors in generator tests

2c03d29

Previously a test would pass if an error was returned due to early exit

Remove new types from IM cache on generate error

978d6a4

Previously they would hang around until database restart - corrupting the schema and preventing schema correction

AndrewSisley added bug Something isn't working area/schema Related to the schema system labels Jan 18, 2022

AndrewSisley requested review from jsimnz and shahzadlone January 18, 2022 17:33

AndrewSisley self-assigned this Jan 18, 2022

jsimnz approved these changes Jan 27, 2022

View reviewed changes

AndrewSisley merged commit 4652589 into develop Jan 27, 2022

AndrewSisley deleted the sisley/fix/I104-generator-errors-clear-schema branch January 27, 2022 12:38

orpheuslummis mentioned this pull request Jan 29, 2022

Changelog creation #151

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Remove new types from in-memory cache on generate error #122

fix: Remove new types from in-memory cache on generate error #122

AndrewSisley commented Jan 18, 2022

codecov bot commented Jan 18, 2022

jsimnz left a comment

fix: Remove new types from in-memory cache on generate error #122

fix: Remove new types from in-memory cache on generate error #122

Conversation

AndrewSisley commented Jan 18, 2022

codecov bot commented Jan 18, 2022

Codecov Report

jsimnz left a comment

Choose a reason for hiding this comment