fix: Allow newly added fields to sync via p2p #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
bug
Codecov Report
@@ Coverage Diff @@
## develop #1226 +/- ##
===========================================
- Coverage 70.74% 70.60% -0.15%
===========================================
Files 182 182
Lines 17133 17138 +5
===========================================
- Hits 12121 12100 -21
- Misses 4091 4109 +18
- Partials 921 929 +8
|
fredcarle
approved these changes
Mar 27, 2023
AndrewSisley
force-pushed
the
sisley/fix/I1185-new-fields-p2p
branch
3 times, most recently
from
4497e3a
to
17ae8c6
Compare
AndrewSisley
changed the title
AndrewSisley
changed the title
AndrewSisley
force-pushed
the
sisley/fix/I1185-new-fields-p2p
branch
2 times, most recently
from
c0ab822
to
66bd567
Compare
AndrewSisley
changed the title
Oddly, everywhere in our codebase apart from a single line in the P2P code hardcodes field CRDT Type to LWW_Register, even if FieldDescription.Typ is readily available.
AndrewSisley
force-pushed
the
sisley/fix/I1185-new-fields-p2p
branch
from
66bd567
to
687b0e8
Compare
shahzadlone
pushed a commit
that referenced
this pull request
Apr 13, 2023
* Document FieldDescription.Typ * Default Field CRDT Type to LWW_Register Oddly, everywhere in our codebase apart from a single line in the P2P code hardcodes field CRDT Type to LWW_Register, even if FieldDescription.Typ is readily available.
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
* Document FieldDescription.Typ * Default Field CRDT Type to LWW_Register Oddly, everywhere in our codebase apart from a single line in the P2P code hardcodes field CRDT Type to LWW_Register, even if FieldDescription.Typ is readily available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #1185
Description
Allows newly added fields to sync via P2P. Was a much much easier fix than I expected - problem was that field CRDT Type was not set, and no where in our codebase besides a single line in the P2P system actually cared or used it - the rest are just hardcoded to LWW_Register (#1225).
I dont want users to have to explicitly specify this, so it defaults to LWW_Register if not set.
This is not a breaking change in that the cids have only changed for new fields being added. It does mean that any databases who have added new fields in the few weeks since adding that feature have a broken database, but I dont think we need to worry about that (given current Defra usage).