fix: Dont lock datastore lock within lock 3 #1273
Merged
+91
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
bug
Codecov Report
@@ Coverage Diff @@
## develop #1273 +/- ##
===========================================
- Coverage 70.27% 70.23% -0.04%
===========================================
Files 184 184
Lines 17791 17798 +7
===========================================
- Hits 12502 12500 -2
- Misses 4340 4347 +7
- Partials 949 951 +2
|
AndrewSisley
changed the title
AndrewSisley
force-pushed
the
sisley/fix/I1154-fix-ds-deadlock-3
branch
from
734c9fd
to
2bf7e48
Compare
Can result in a deadlock.
AndrewSisley
force-pushed
the
sisley/fix/I1154-fix-ds-deadlock-3
branch
from
2bf7e48
to
036d7c5
Compare
fredcarle
approved these changes
Apr 4, 2023
shahzadlone
pushed a commit
that referenced
this pull request
Apr 13, 2023
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #1154
Description
An alternative solution to #1261 that removes the shared lock completely, at the cost of a pointer in the txn tree and a mutex and bool on the txn.