fix: Update immutable package #1290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark ResultsSummary
✅ See Better Results...
❌ See Worse Results...
✨ See Unchanged Results...
🐋 See Full Results... |
|||||||||||||||
shahzadlone
previously requested changes
Apr 5, 2023
go.sum
Outdated
Comment on lines
911
to
912
| github.com/sourcenetwork/immutable v0.2.1 h1:0SAnoiGm1XQG+xiG4gK4nmLFqTMRnQ5Y1N4WHL7vQtE= | ||
| github.com/sourcenetwork/immutable v0.2.1/go.mod h1:4jpxObkIQw8pvlIRm4ndZqf3pH9ZjYEw/UYI6GZDJww= |
There was a problem hiding this comment.
todo: These two lines shouldn't exist (ones with v0.2.1). Run make tidy it should fix that by removing these.
Codecov Report
@@ Coverage Diff @@
## develop #1290 +/- ##
===========================================
+ Coverage 70.40% 70.47% +0.07%
===========================================
Files 184 184
Lines 17825 17825
===========================================
+ Hits 12549 12563 +14
+ Misses 4320 4310 -10
+ Partials 956 952 -4 |
Benchmark ResultsSummary
✅ See Better Results...
❌ See Worse Results...
✨ See Unchanged Results...
🐋 See Full Results... |
|||||||||||||||
fredcarle
approved these changes
Apr 5, 2023
islamaliev
force-pushed
the
islam/fix/I1289-immutable-with-custom-marshal
branch
from
be12b69
to
58e9b30
Compare
Benchmark ResultsSummary
✅ See Better Results...
❌ See Worse Results...
✨ See Unchanged Results...
🐋 See Full Results... |
|||||||||||||||
New version adds custom un/marshaling
islamaliev
force-pushed
the
islam/fix/I1289-immutable-with-custom-marshal
branch
from
58e9b30
to
bfd223b
Compare
shahzadlone
pushed a commit
that referenced
this pull request
Apr 13, 2023
New version adds custom un/marshaling
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
New version adds custom un/marshaling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New version adds custom un/marshaling
Relevant issue(s)
Resolves #1289
Description
Update
immutablepackage that added customMarshalJSONandUnmarshalJSONmethod toimmutable.OptionTasks
How has this been tested?
Integration tests and manual tests.
Specify the platform(s) on which this was tested: