Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add Islam as contributor #1302

Merged
merged 1 commit into from
Apr 6, 2023
Merged

chore: Add Islam as contributor #1302

merged 1 commit into from
Apr 6, 2023

Conversation

islamaliev
Copy link
Contributor

@islamaliev islamaliev commented Apr 6, 2023 •
edited
Loading

Relevant issue(s)

Resolves #1292

Description

Adds Islam to the list of contributors

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

No need for testing

@islamaliev islamaliev linked an issue Apr 6, 2023 that may be closed by this pull request
Islam is not listed in set of contributors at bottom of readme #1292
Closed
@islamaliev islamaliev self-assigned this Apr 6, 2023
@islamaliev islamaliev added this to the DefraDB v0.5 milestone Apr 6, 2023
@islamaliev islamaliev added bug Something isn't working documentation Improvements or additions to documentation labels Apr 6, 2023
@source-devs
Copy link

Benchmark Results

Summary

  • 0 Benchmarks successfully compared.
  • 0 Benchmarks were ✅ Better.
  • 0 Benchmarks were ❌ Worse .
  • 0 Benchmarks were ✨ Unchanged.
✅ See Better Results...
time/opdelta
 
❌ See Worse Results...
time/opdelta
 
✨ See Unchanged Results...
time/opdelta
 
🐋 See Full Results...

@jsimnz jsimnz changed the title fix: Add Islam as contributor chore: Add Islam as contributor Apr 6, 2023
@jsimnz jsimnz added meta/dev These issues related to the meta elements of the code base like dev flow, repo logistics, and PM action/no-benchmark Skips the action that runs the benchmark. and removed bug Something isn't working labels Apr 6, 2023
@jsimnz
Copy link
Member

jsimnz commented Apr 6, 2023

🥳

@islamaliev islamaliev merged commit 4f64feb into develop Apr 6, 2023
@islamaliev islamaliev deleted the islam/fix/I1292-islam-contributor branch April 6, 2023 08:34
shahzadlone pushed a commit that referenced this pull request Apr 13, 2023
@islamaliev @shahzadlone
chore: Add Islam as contributor (#1302)
dc9da08 
Add Islam as contributor
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@islamaliev
chore: Add Islam as contributor (sourcenetwork#1302)
c5c1628 
Add Islam as contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahzadlone shahzadlone shahzadlone approved these changes

Assignees

@islamaliev islamaliev

Labels
action/no-benchmark Skips the action that runs the benchmark. documentation Improvements or additions to documentation meta/dev These issues related to the meta elements of the code base like dev flow, repo logistics, and PM
Projects
None yet
Milestone
DefraDB v0.5
Development

Successfully merging this pull request may close these issues.

Islam is not listed in set of contributors at bottom of readme
4 participants
@islamaliev @source-devs @jsimnz @shahzadlone