fix: Only check for events queue on subscription request #1326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested by running a few of the integration tests having hacked away the WithUpdateEvents db option in utils2.go.
AndrewSisley
added
bug
Codecov Report
@@ Coverage Diff @@
## develop #1326 +/- ##
===========================================
- Coverage 70.55% 70.51% -0.05%
===========================================
Files 184 184
Lines 17784 17786 +2
===========================================
- Hits 12548 12541 -7
- Misses 4284 4290 +6
- Partials 952 955 +3
|
shahzadlone
pushed a commit
that referenced
this pull request
Apr 13, 2023
* Only check for events queue if subscr. req Tested by running a few of the integration tests having hacked away the WithUpdateEvents db option in utils2.go.
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
…rk#1326) * Only check for events queue if subscr. req Tested by running a few of the integration tests having hacked away the WithUpdateEvents db option in utils2.go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #1189
Description
Only checks for the events queue on subscription request. This makes the optional
WithUpdateEventsdatabase (constructor) option optional again (it would error without it for any kind of non-introspection request).Tested by running a few of the integration tests having hacked away the WithUpdateEvents db option in utils2.go, also checked that without the fix the hacks would result in an error.
As the integration test framework does not allow for db configuration atm, and we are planning on releasing today I am skimping on adding proper automated tests for this right now.