Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky Test - TestP2PWithMultipleDocumentUpdatesPerNode #1336

Closed
shahzadlone opened this issue Apr 12, 2023 · 0 comments · Fixed by #1388
Closed

Flaky Test - TestP2PWithMultipleDocumentUpdatesPerNode #1336

shahzadlone opened this issue Apr 12, 2023 · 0 comments · Fixed by #1388
Assignees
@fredcarle
Labels
bug Something isn't working
Milestone
DefraDB v0.5.1

Comments

@shahzadlone
Copy link
Member

Describe the problem
Flakey test.

To Reproduce
make test

Expected behavior
Not be flaky

Platform

latest commit on develop:
bbe8408a (HEAD -> develop, origin/develop) 2 hours ago fix: API address parameter validation (#1311)

Additional context

...

=== Failed
=== FAIL: datastore/badger/v3 TestGetSizeOperationWithStoreClosed (unknown)

=== FAIL: tests/integration/net/state/simple/peer TestP2PWithMultipleDocumentUpdatesPerNode (unknown)
2023-04-12T10:58:57.907-0400    ERROR   dht     [email protected]/subscriber_notifee.go:108     could not check peerstore for protocol support: err: datastore closed
2023-04-12T10:58:57.908-0400    ERROR   dht     [email protected]/subscriber_notifee.go:108     could not check peerstore for protocol support: err: datastore closed
2023-04-12T10:58:57.908-0400    ERROR   dht     [email protected]/subscriber_notifee.go:108     could not check peerstore for protocol support: err: datastore closed
2023-04-12T10:58:57.910-0400    ERROR   peerstore/ds    pstoreds/keybook.go:63  error when fetching pubkey from datastore for peer 12D3KooWEyKsi421kF382prWWJt8Vzz7nCTb982jTwthT3aoChwG: datastore closed

2023-04-12T10:58:57.911-0400    ERROR   peerstore/ds    pstoreds/keybook.go:81  error while updating pubkey in datastore for peer 12D3KooWEyKsi421kF382prWWJt8Vzz7nCTb982jTwthT3aoChwG: datastore closed

2023-04-12T10:58:57.915-0400, INFO, defra.tests.integration, , {"Database": "badger-in-memory"}
2023-04-12T10:58:57.981-0400, INFO, defra.tests.integration, Starting P2P node, {"P2P address": "/ip4/0.0.0.0/tcp/0"}
2023-04-12T10:58:58.076-0400, INFO, defra.node, Created LibP2P host, {"PeerId": "12D3KooWFE4XEa4uUAEchG5kRdWtZjZFcjmP6aZ3otNuMHNc3rVT", "Address": ["/ip4/0.0.0.0/tcp/0"]}
2023-04-12T10:58:58.081-0400, INFO, defra.net, Starting internal broadcaster for pubsub network
2023-04-12T10:58:58.106-0400, INFO, defra.tests.integration, Starting P2P node, {"P2P address": "/ip4/0.0.0.0/tcp/0"}
2023-04-12T10:58:58.326-0400, INFO, defra.node, Created LibP2P host, {"PeerId": "12D3KooWExFEg7GVEawm61f2ajdXMCdQh8aXCqL4ZhnYJaopc2Ab", "Address": ["/ip4/0.0.0.0/tcp/0"]}
2023-04-12T10:58:58.384-0400, INFO, defra.net, Starting internal broadcaster for pubsub network
2023-04-12T10:58:58.557-0400, INFO, defra.tests.integration, Parsing bootstrap peers, {"Peers": "/ip4/172.27.231.49/tcp/40643/p2p/12D3KooWExFEg7GVEawm61f2ajdXMCdQh8aXCqL4ZhnYJaopc2Ab"}
2023-04-12T10:58:58.558-0400, INFO, defra.tests.integration, Bootstrapping with peers, {"Addresses": [{"ID":"12D3KooWExFEg7GVEawm61f2ajdXMCdQh8aXCqL4ZhnYJaopc2Ab","Addrs":["/ip4/172.27.231.49/tcp/40643"]}]}
2023-04-12T10:58:58.684-0400, INFO, defra.net, Received new pubsub event, {"SenderId": "12D3KooWFE4XEa4uUAEchG5kRdWtZjZFcjmP6aZ3otNuMHNc3rVT", "Topic": "bae-52b9170d-b77a-5887-b877-cbdbb99b009f", "Message": "JOINED"}
2023-04-12T10:58:58.689-0400, INFO, defra.node, Connected, {"Peer ID": "12D3KooWExFEg7GVEawm61f2ajdXMCdQh8aXCqL4ZhnYJaopc2Ab"}
2023-04-12T10:58:58.794-0400, INFO, defra.merkleclock, Replacing DAG head, {"Old": "bafybeibikyvp4kiwgvbdm7skhsnglvksquih6suj6adxsryiwxfol7rhky", "CID": "bafybeicp7jguntelc4svy2iqty65vkp47iqrkegplwlhtq3lmajnmlqrji", "Height": 2}
2023-04-12T10:58:59.146-0400, INFO, defra.merkleclock, Replacing DAG head, {"Old": "bafybeih45xhodaynmvu3pehetcjkcjvs5fgnm2z454yzztce6jdzn2xw4u", "CID": "bafybeigehyhrm5igewfcohbasz7kp3cyqu65jxfnvigcinpkbe2empfyta", "Height": 2}
2023-04-12T10:58:59.151-0400, INFO, defra.merkleclock, Replacing DAG head, {"Old": "bafybeicp7jguntelc4svy2iqty65vkp47iqrkegplwlhtq3lmajnmlqrji", "CID": "bafybeifhvkbnvjrlq54ccrn2utyni7fsj5b2y67gksludgsyyqu3ojf2ge", "Height": 3}
2023-04-12T10:58:59.153-0400, INFO, defra.merkleclock, Replacing DAG head, {"Old": "bafybeigehyhrm5igewfcohbasz7kp3cyqu65jxfnvigcinpkbe2empfyta", "CID": "bafybeigfuvr64slsxmkppkb5h7czhzfqpvlavsg3fljsste4hplk2m6u7a", "Height": 3}
2023-04-12T10:58:59.155-0400, INFO, defra.merkleclock, Replacing DAG head, {"Old": "bafybeifhvkbnvjrlq54ccrn2utyni7fsj5b2y67gksludgsyyqu3ojf2ge", "CID": "bafybeig3tjzvvku7ejjuzczl4mkli32fzlnelgtotw2qhzwfwgljrtkun4", "Height": 4}
2023-04-12T10:58:59.162-0400, INFO, defra.net, Received new pubsub event, {"SenderId": "12D3KooWExFEg7GVEawm61f2ajdXMCdQh8aXCqL4ZhnYJaopc2Ab", "Topic": "bae-52b9170d-b77a-5887-b877-cbdbb99b009f", "Message": "JOINED"}
2023-04-12T10:58:59.202-0400, INFO, defra.merkleclock, Replacing DAG head, {"Old": "bafybeigfuvr64slsxmkppkb5h7czhzfqpvlavsg3fljsste4hplk2m6u7a", "CID": "bafybeiec3n3mzmqj4j3opvzzfqqbfq6ll3442mycwc2vhnvne7ia75hzse", "Height": 4}
2023-04-12T10:58:59.209-0400, INFO, defra.merkleclock, Replacing DAG head, {"Old": "bafybeibikyvp4kiwgvbdm7skhsnglvksquih6suj6adxsryiwxfol7rhky", "CID": "bafybeiaiwrezgutkyabi3pazplwefat52oq52v5byqb64kqvnxyt7lsqom", "Height": 2}
2023-04-12T10:58:59.211-0400, INFO, defra.merkleclock, Replacing DAG head, {"Old": "bafybeih45xhodaynmvu3pehetcjkcjvs5fgnm2z454yzztce6jdzn2xw4u", "CID": "bafybeid2dcrc7342ownxdudn57luuxud3kj74joezbof4lrdap4ancbq64", "Height": 2}
2023-04-12T10:58:59.348-0400, INFO, defra.merkleclock, Replacing DAG head, {"Old": "bafybeiaiwrezgutkyabi3pazplwefat52oq52v5byqb64kqvnxyt7lsqom", "CID": "bafybeia3hiix2iotxxzlpq7i4uzmwx3oyxwffgv4q43bn246pgy4eackvy", "Height": 3}
2023-04-12T10:58:59.397-0400, INFO, defra.merkleclock, Replacing DAG head, {"Old": "bafybeid2dcrc7342ownxdudn57luuxud3kj74joezbof4lrdap4ancbq64", "CID": "bafybeiaqutvj53ewhqrwufmkftqylos2tg5v4nloyr5ha4syfyrlszs3q4", "Height": 3}
2023-04-12T10:58:59.400-0400, INFO, defra.merkleclock, Replacing DAG head, {"Old": "bafybeia3hiix2iotxxzlpq7i4uzmwx3oyxwffgv4q43bn246pgy4eackvy", "CID": "bafybeibawlibuovkdtxjf6s3e7mg4jaob5w25ffdb7gu3q6svapj5yupay", "Height": 4}
2023-04-12T10:58:59.402-0400, INFO, defra.merkleclock, Replacing DAG head, {"Old": "bafybeiaqutvj53ewhqrwufmkftqylos2tg5v4nloyr5ha4syfyrlszs3q4", "CID": "bafybeicxzwspmu5rsttyhxy3xtroxi34askh7v2obkz6bljezp3emohof4", "Height": 4}
2023-04-12T10:58:59.512-0400, INFO, defra.merkleclock, Replacing DAG head, {"Old": "bafybeibikyvp4kiwgvbdm7skhsnglvksquih6suj6adxsryiwxfol7rhky", "CID": "bafybeicp7jguntelc4svy2iqty65vkp47iqrkegplwlhtq3lmajnmlqrji", "Height": 2}
2023-04-12T10:58:59.585-0400, INFO, defra.merkleclock, Replacing DAG head, {"Old": "bafybeih45xhodaynmvu3pehetcjkcjvs5fgnm2z454yzztce6jdzn2xw4u", "CID": "bafybeigehyhrm5igewfcohbasz7kp3cyqu65jxfnvigcinpkbe2empfyta", "Height": 2}
2023-04-12T10:58:59.918-0400, INFO, defra.merkleclock, Replacing DAG head, {"Old": "bafybeiaiwrezgutkyabi3pazplwefat52oq52v5byqb64kqvnxyt7lsqom", "CID": "bafybeia3hiix2iotxxzlpq7i4uzmwx3oyxwffgv4q43bn246pgy4eackvy", "Height": 3}
2023-04-12T10:59:00.051-0400, INFO, defra.merkleclock, Replacing DAG head, {"Old": "bafybeid2dcrc7342ownxdudn57luuxud3kj74joezbof4lrdap4ancbq64", "CID": "bafybeiaqutvj53ewhqrwufmkftqylos2tg5v4nloyr5ha4syfyrlszs3q4", "Height": 3}
2023-04-12T10:59:00.125-0400, INFO, defra.merkleclock, Replacing DAG head, {"Old": "bafybeiaiwrezgutkyabi3pazplwefat52oq52v5byqb64kqvnxyt7lsqom", "CID": "bafybeia3hiix2iotxxzlpq7i4uzmwx3oyxwffgv4q43bn246pgy4eackvy", "Height": 3}
2023-04-12T10:59:00.127-0400, INFO, defra.merkleclock, Replacing DAG head, {"Old": "bafybeid2dcrc7342ownxdudn57luuxud3kj74joezbof4lrdap4ancbq64", "CID": "bafybeiaqutvj53ewhqrwufmkftqylos2tg5v4nloyr5ha4syfyrlszs3q4", "Height": 3}
2023-04-12T10:59:00.193-0400, INFO, defra.merkleclock, Replacing DAG head, {"Old": "bafybeicp7jguntelc4svy2iqty65vkp47iqrkegplwlhtq3lmajnmlqrji", "CID": "bafybeifhvkbnvjrlq54ccrn2utyni7fsj5b2y67gksludgsyyqu3ojf2ge", "Height": 3}
    p2p.go:476:
                Error Trace:    /home/shahzad/~~/defradb/tests/integration/p2p.go:476
                                                        /home/shahzad/~~/defradb/tests/integration/utils2.go:396
                                                        /home/shahzad/~~/defradb/tests/integration/utils2.go:289
                                                        /home/shahzad/~~/defradb/tests/integration/net/state/simple/peer/with_update_test.go:422
                Error:          timeout occured while waiting for data stream
                Test:           TestP2PWithMultipleDocumentUpdatesPerNode

DONE 1295 tests, 2 failures in 147.509s
make: *** [Makefile:146: test] Error 1
@shahzadlone shahzadlone added the bug Something isn't working label Apr 12, 2023
@shahzadlone shahzadlone added this to the DefraDB v0.5.1 milestone Apr 12, 2023
@shahzadlone shahzadlone mentioned this issue Apr 12, 2023
Open
@fredcarle fredcarle mentioned this issue Apr 21, 2023
Merged
4 tasks
@fredcarle fredcarle self-assigned this Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fredcarle fredcarle

Labels
bug Something isn't working
Projects
None yet
Milestone
DefraDB v0.5.1
Development

Successfully merging a pull request may close this issue.

fix: Improve P2P event handling sourcenetwork/defradb
2 participants
@fredcarle @shahzadlone