-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Use more accurate test coverage. #134
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #134 +/- ##
============================================
+ Coverage 52.86% 63.86% +11.00%
============================================
Files 35 80 +45
Lines 3757 7328 +3571
============================================
+ Hits 1986 4680 +2694
- Misses 1541 2163 +622
- Partials 230 485 +255
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left a comment about the -race
command based on our conversation earlier on discord. Let me know what the final descision was.
# This only covers how much of the package is tested by itself (unit test). | ||
.PHONY: test\:coverage-quick | ||
test\:coverage-quick: | ||
go test ./... -race -coverprofile=coverage-quick.txt -covermode=atomic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you guys make a descision regarding the -race
flag on the coverage-quick
make command?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this coverage-quick
rule isn't ran on any CI steps, just there for local coverage report generation of only unit tests (so no integration / cross package coverage).
We did decide to go with -race
flag for the benefits. I checked locally the running time difference is like just a few seconds.
I can include the -race flag in the PR and then merge.
In addition to better coverage also add the `-race` flag to our checks to detect races.
Use more accurate test coverage which makes our tests 63.5% covered as it now also accounts for integration tests.