Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Bump go version within packer for AWS AMI #1344

Merged
merged 2 commits into from
Apr 16, 2023

Conversation

shahzadlone
Copy link
Member

Relevant issue(s)

Resolves #1343

Description

Fixes the issue by bumping Golang dependency it will build to v1.19.8.

How has this been tested?

Manually on v0.5.0, here is the passing action: https://github.com/sourcenetwork/defradb/actions/runs/4684981654/jobs/8301658218

Specify the platform(s) on which this was tested:

  • WSL2 (Manjaro)

@shahzadlone shahzadlone added bug Something isn't working ci/build This is issue is about the build or CI system, and the administration of it. dependencies Related to dependencies labels Apr 13, 2023
@shahzadlone shahzadlone added this to the DefraDB v0.5.1 milestone Apr 13, 2023
@shahzadlone shahzadlone requested a review from a team April 13, 2023 03:09
@shahzadlone shahzadlone self-assigned this Apr 13, 2023
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #1344 (03ce011) into develop (5b08fa0) will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1344      +/-   ##
===========================================
- Coverage    70.67%   70.56%   -0.12%     
===========================================
  Files          184      184              
  Lines        17818    17818              
===========================================
- Hits         12593    12573      -20     
- Misses        4273     4288      +15     
- Partials       952      957       +5     

see 6 files with indirect coverage changes

@shahzadlone shahzadlone added the action/no-benchmark Skips the action that runs the benchmark. label Apr 13, 2023
@sourcenetwork sourcenetwork deleted a comment from source-devs Apr 13, 2023
@shahzadlone shahzadlone changed the title ci: Bump GoLang version for AWS AMI ci: Bump go version within packer for AWS AMI Apr 13, 2023
Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahzadlone shahzadlone force-pushed the lone/update-packer-golang-version branch from 4e54803 to 03ce011 Compare April 16, 2023 09:45
@shahzadlone shahzadlone merged commit 8a6ac5f into develop Apr 16, 2023
@shahzadlone shahzadlone deleted the lone/update-packer-golang-version branch April 16, 2023 10:26
shahzadlone added a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
- Resolves sourcenetwork#1343

- Description: Bumping Golang dependency version within packer to `v1.19.8`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/no-benchmark Skips the action that runs the benchmark. bug Something isn't working ci/build This is issue is about the build or CI system, and the administration of it. dependencies Related to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update in packer the aws ami golang version while building deps for defradb
2 participants