fix: Use ring-buffer for WaitForFoo chans #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
bug
Codecov Report
@@ Coverage Diff @@
## develop #1359 +/- ##
===========================================
- Coverage 70.65% 70.55% -0.11%
===========================================
Files 184 184
Lines 17818 17833 +15
===========================================
- Hits 12590 12582 -8
- Misses 4275 4294 +19
- Partials 953 957 +4
|
fredcarle
approved these changes
Apr 17, 2023
AndrewSisley
commented
Apr 17, 2023
| pubSubEvent: make(chan net.EvtPubSub), | ||
| pushLogEvent: make(chan net.EvtReceivedPushLog), | ||
| peerEvent: make(chan event.EvtPeerConnectednessChanged), | ||
| // WARNING: The current usage of these channels means that consumers of them |
There was a problem hiding this comment.
note: There is a chance that this 'feature' may enable tests to pass when they should not, if for example the WaitForFoo funcs are called later than they should.
There was a problem hiding this comment.
That is very true. But it would have been the case before as well but limited to the size of the event bus channel instead of the node channels above.
There was a problem hiding this comment.
Ah true! That's an interesting thought too, I wonder if that has been affecting things
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
Fixes a deadlock-like situation within P2P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #1357
Description
Introduces ring-buffer mechanics for WaitForFoo chans. This means that the go routines modified should never block, and that means that the libp2p
EventBusshould never fill to capacity, meaning it too should never block, which means the main P2P code should never block when doing P2P stuff (e.g. when callingEventBus.Emitinserver.PushLog).Massive thanks to Fred and John for showing me a very simple way of creating a ring-buffer in Go, I thought it would be way more complicated to do this.