Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move to gofrs/uuid #1396

Conversation

fredcarle
Copy link
Collaborator

Relevant issue(s)

Resolves #1221

Description

This PR changes github.com/satori/go.uuid for github.com/gofrs/uuid/v5.

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

make test

Specify the platform(s) on which this was tested:

  • MacOS

@fredcarle fredcarle added action/no-benchmark Skips the action that runs the benchmark. dependencies Related to dependencies labels Apr 23, 2023
@fredcarle fredcarle added this to the DefraDB v0.5.1 milestone Apr 23, 2023
@fredcarle fredcarle requested a review from a team April 23, 2023 02:04
@fredcarle fredcarle self-assigned this Apr 23, 2023
@fredcarle fredcarle changed the title chore: Move to gofrs/uuid chore: Move to gofrs/uuid Apr 23, 2023
Copy link
Contributor

@orpheuslummis orpheuslummis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@AndrewSisley AndrewSisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@shahzadlone shahzadlone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fredcarle fredcarle force-pushed the fredcarle/chore/I1221-move-from-go.uuid branch from 6ea6a85 to 4ca0ab2 Compare April 24, 2023 22:40
@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #1396 (4ca0ab2) into develop (0e08406) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1396      +/-   ##
===========================================
+ Coverage    70.71%   70.77%   +0.06%     
===========================================
  Files          185      185              
  Lines        17884    17884              
===========================================
+ Hits         12646    12657      +11     
+ Misses        4285     4277       -8     
+ Partials       953      950       -3     
Impacted Files Coverage Δ
client/dockey.go 51.16% <ø> (ø)

... and 4 files with indirect coverage changes

@fredcarle fredcarle merged commit 8f853d2 into sourcenetwork:develop Apr 24, 2023
@fredcarle fredcarle deleted the fredcarle/chore/I1221-move-from-go.uuid branch April 27, 2023 17:24
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
Description
This PR changes github.com/satori/go.uuid for github.com/gofrs/uuid/v5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/no-benchmark Skips the action that runs the benchmark. dependencies Related to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest satori/go.uuid/ dependency is vulnerable
4 participants