Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Correcting README typos #140

Merged
merged 1 commit into from
Jan 25, 2022
Merged

docs: Correcting README typos #140

merged 1 commit into from
Jan 25, 2022

Conversation

orpheuslummis
Copy link
Contributor

No description provided.

shahzadlone
shahzadlone approved these changes Jan 25, 2022
View reviewed changes
Copy link
Member

@shahzadlone shahzadlone left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for these!

LGTM (just change the PR title as described below).

@shahzadlone
Copy link
Member

shahzadlone commented Jan 25, 2022 •
edited
Loading

@orpheuslummis we use conventional style commits.

The first word after the : should be an action (in present tense). So a title for this PR can be something like:

docs: Correcting README typos.

@orpheuslummis orpheuslummis changed the title fix: README typos docs: Correcting README typos Jan 25, 2022
@shahzadlone
Copy link
Member

@orpheuslummis All yours to squash :P

@orpheuslummis orpheuslummis merged commit 22e2518 into develop Jan 25, 2022
@orpheuslummis orpheuslummis deleted the orpheus/typo-fix branch January 25, 2022 18:05
@orpheuslummis orpheuslummis mentioned this pull request Jan 29, 2022
Closed
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@orpheuslummis
docs: Correcting README typos (sourcenetwork#140)
a18f8ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahzadlone shahzadlone shahzadlone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orpheuslummis @shahzadlone