ci: Fix the SSH security issue from AMI scan report #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahzadlone
added
ci/build
shahzadlone
added
the
action/no-benchmark
shahzadlone
force-pushed
the
lone/ci/shred-all-ssh-keys-for-security
branch
from
f35f606
to
64f1a34
Compare
shahzadlone
force-pushed
the
lone/ci/shred-all-ssh-keys-for-security
branch
4 times, most recently
from
8b7e781
to
1b46a46
Compare
Remove from under `/etc`, `/root/`, and `home/*`.
shahzadlone
force-pushed
the
lone/ci/shred-all-ssh-keys-for-security
branch
from
1b46a46
to
8cd844a
Compare
|
Were the secrets only useful pre open sourcing ? |
The ones where I removed them from in this PR, yes. But there are a few other places they are used where they are required and still useful (for PR commenting, etc.) |
shahzadlone
added a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
## Relevant issue(s) Resolves sourcenetwork#1425 ## Description - Shreds the keys in all locations noted in the issue. - Generated the AMI of name: `source-defradb-v0.5.0-20230501085514` , with ID: `ami-0814ed8a30589825b` - The run that generated the AMI successfully can be found here: https://github.com/sourcenetwork/defradb/actions/runs/4849906529/jobs/8642330562?pr=1426
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #1425
Description
source-defradb-v0.5.0-20230501085514, with ID:ami-0814ed8a30589825bHow has this been tested?