-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Add a separate workflow to run the linter #1434
ci: Add a separate workflow to run the linter #1434
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1434 +/- ##
===========================================
- Coverage 72.21% 72.17% -0.05%
===========================================
Files 185 185
Lines 18160 18160
===========================================
- Hits 13115 13107 -8
- Misses 4012 4018 +6
- Partials 1033 1035 +2 |
595c4ab
to
29f4db5
Compare
1dde5c6
to
29f4db5
Compare
question: Why does this not remove the lint stuff from the lint-then-benchmark workflow? |
29f4db5
to
9cf98b0
Compare
That entire workflow file will be disabled after this is merged. I don't want to make changes to that workflow as it will be dead until we fix it (would rather preserve it in the state it used to work rather than in a changed further broken state). |
Those are good reasons, cheers for the explanation :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
## Relevant issue(s) Resolves sourcenetwork#1435 ## Description Add a Lint only workflow. ## How has this been tested? CI on branch of a fork and this PR
Relevant issue(s)
Resolves #1435
Description
Add a Lint only workflow.
How has this been tested?
CI on branch of a fork and this PR