test: Capitalize all integration schema types #1445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsimnz
added
area/testing
Codecov Report
@@ Coverage Diff @@
## develop #1445 +/- ##
===========================================
- Coverage 72.23% 72.13% -0.11%
===========================================
Files 185 185
Lines 18160 18160
===========================================
- Hits 13118 13099 -19
- Misses 4010 4024 +14
- Partials 1032 1037 +5 |
|
Sorry about the hound comments, I was testing it out haha. |
Lol was wondering about this 😂 |
AndrewSisley
approved these changes
May 3, 2023
|
Yes thanks John for picking it up when I ran out of steam with it!!
|
4 tasks
shahzadlone
approved these changes
May 3, 2023
There was a problem hiding this comment.
Thanks for taking care of this @jsimnz and @orpheuslummis
I am sorry @jsimnz you might have to take care of conflicts within tests/integration/explain/default/with_limit*_test.go.
Also change detector I noticed fails so that will need to be resolved before merge too.
Giving approval :)
jsimnz
force-pushed
the
jsimnz/chore/gql-capitalization
branch
from
ff80f40
to
5c7714a
Compare
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
This converts all schemas in the integrations folder to follow GQL best practices' where the type name is capitalized and the fields are lowercase. The *only* things that should be changed throughout the PR is: A) Capitalization of schema types, and lowercase of fields (this is also represented through queries, mutations, etc) B) CIDs - as the schemas are involved in generated the CIDs since the `schemaVersionID` is embedded in the commits. C) DocKeys - Same reason as above D) Reordering of *some* request results as the implicit order (dockeys) of various results have changed because of (C). --------- Co-authored-by: Orpheus Lummis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #807
Description
This converts all schemas in the integrations folder to follow GQL best practices' where the type name is capitalized and the fields are lowercase.
Do not review commit by commit, as they aren't necessarily logically grouped, as this was a long process and spread over all kinds of copy/pastes, search/replaces, and lots (lots) of regex (cringe).
The only things that should be changed throughout the PR is:
A) Capitalization of schema types, and lowercase of fields (this is also represented through queries, mutations, etc)
B) CIDs - as the schemas are involved in generated the CIDs since the
schemaVersionIDis embedded in the commits.C) DocKeys - Same reason as above
D) Reordering of some request results as the implicit order (dockeys) of various results have changed because of (C).
If any other change is noticed that doesn't fall into those categories, please note it :)
Tasks
How has this been tested?
CI
Specify the platform(s) on which this was tested: