Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add tests to assert schema id order independence #1456

Merged
merged 1 commit into from
May 5, 2023
Merged

test: Add tests to assert schema id order independence #1456

merged 1 commit into from
May 5, 2023

Conversation

AndrewSisley
Copy link
Contributor

Relevant issue(s)

Resolves #863

Description

Adds tests to assert schema id order independence. Ticket suggested the go json lib is order dependent, this appears to be untrue.

@AndrewSisley AndrewSisley added area/schema Related to the schema system action/no-benchmark Skips the action that runs the benchmark. labels May 5, 2023
@AndrewSisley AndrewSisley added this to the DefraDB v0.5.1 milestone May 5, 2023
@AndrewSisley AndrewSisley requested a review from a team May 5, 2023 17:02
@AndrewSisley AndrewSisley self-assigned this May 5, 2023
fredcarle
fredcarle approved these changes May 5, 2023
View reviewed changes
Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for confirming this Andy. I think if cbor is something we want regardless, we can come back to it in a future cycle.

@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #1456 (acb9db5) into develop (1dcfcae) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1456      +/-   ##
===========================================
+ Coverage    72.17%   72.20%   +0.02%     
===========================================
  Files          185      185              
  Lines        18224    18224              
===========================================
+ Hits         13154    13158       +4     
+ Misses        4032     4029       -3     
+ Partials      1038     1037       -1

see 3 files with indirect coverage changes

@AndrewSisley AndrewSisley merged commit 3e47baf into sourcenetwork:develop May 5, 2023
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@AndrewSisley
test: Add tests to assert schema id order independence (sourcenetwork…
ca9f975 
…#1456)

## Relevant issue(s)

Resolves sourcenetwork#863

## Description

Adds tests to assert schema id order independence. Ticket suggested the
go json lib is order dependent, this appears to be untrue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredcarle fredcarle fredcarle approved these changes

Assignees

@AndrewSisley AndrewSisley

Labels
action/no-benchmark Skips the action that runs the benchmark. area/schema Related to the schema system
Projects
None yet
Milestone
DefraDB v0.5.1
Development

Successfully merging this pull request may close these issues.

Use order independant CID generation for SchemaID
2 participants
@AndrewSisley @fredcarle