Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove some dead code #1470

Merged
merged 1 commit into from
May 9, 2023
Merged

chore: Remove some dead code #1470

merged 1 commit into from
May 9, 2023

Conversation

orpheuslummis
Copy link
Contributor

Relevant issue(s)

Resolves #-

Description

Just some 'dead code' being remove. Feel free to add commits to this PR to remove further dead code.

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

make

@orpheuslummis orpheuslummis added the action/no-benchmark Skips the action that runs the benchmark. label May 9, 2023
@orpheuslummis orpheuslummis added this to the DefraDB v0.5.1 milestone May 9, 2023
@orpheuslummis orpheuslummis self-assigned this May 9, 2023
@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #1470 (9764fc5) into develop (7575209) will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1470      +/-   ##
===========================================
- Coverage    72.25%   72.13%   -0.13%     
===========================================
  Files          185      185              
  Lines        18224    18224              
===========================================
- Hits         13168    13145      -23     
- Misses        4022     4038      +16     
- Partials      1034     1041       +7
Impacted Files Coverage Δ
cli/root.go 66.30% <ø> (ø)

... and 7 files with indirect coverage changes

AndrewSisley
AndrewSisley approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@AndrewSisley AndrewSisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Strongly suggest merging it now, instead of letting it live a long time and expand. If people (yourself included) want to remove more dead code it can be done in another PR :)

tests/integration/utils2.go
@@ -49,19 +48,6 @@ const (
documentationDirectoryName = "data_format_changes"
)

// The integration tests open many files. This increases the limits on the number of open files of
// the process to fix this issue. This is done by default in Go 1.19.
func init() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😁 This isn't really dead code, but we are all on Go 1.19 now I guess :)

@orpheuslummis orpheuslummis merged commit b6bd97a into sourcenetwork:develop May 9, 2023
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@orpheuslummis
chore: Remove some dead code (sourcenetwork#1470)
347d2f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewSisley AndrewSisley AndrewSisley approved these changes

Assignees

@orpheuslummis orpheuslummis

Labels
action/no-benchmark Skips the action that runs the benchmark.
Projects
None yet
Milestone
DefraDB v0.5.1
Development

Successfully merging this pull request may close these issues.
2 participants
@orpheuslummis @AndrewSisley